![[RTEMS Logo]](/images/logo.png){kind=logo}
Opened on 10/27/18 at 19:10:36
Last modified on 10/27/18 at 19:14:42
#3573 new defect
DHCP request includes host name option even if hostname is zero length
| Reported by: | Marçal Comajoan Cara | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | network/legacy | Version: | 4.11 |
| Severity: | normal | Keywords: | DHCP hostname |
| Cc: | Blocked By: | ||
| Blocking: |
Description
DHCP requests add the hostname option in dhcp_request_req() without checking its length, so the hostname can be of any length. This is a defect because the DHCP spec (https://tools.ietf.org/html/rfc2132) requires the hostname to have a minimum length of 1 char.
This appears to trigger a bug in a specific Netgear router that causes it's DHCP process to lock up and could affect other things as well.
This bug can be solved applying the patch made by Aun-Ali Zaidi in the original ticket reporting this defect (https://devel.rtems.org/ticket/1405) that was never applied. I've also attached the patch in this ticket.
I've been able to compile the code with the patch applied and it didn't raise any warnings.
Original ticket: https://devel.rtems.org/ticket/1405
Attachments (1)
Change History (2)
comment:1 Changed on 10/27/18 at 19:14:42 by Marçal Comajoan Cara
| Component: | admin → network/legacy |
|---|
Changed on 11/13/18 at 22:51:02 by Marçal Comajoan Cara
| Attachment: | 0001-libnetworking-rtems_dhcp.c-Fix-improper-hostname-han.2.patch added |
|---|
Patch to check the length of the hostname, therefore to solve the bug.