Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

Opened on 01/23/17 at 19:14:05

Last modified on 01/24/17 at 06:33:08

#2884 assigned defect

src/c/src/lib/libbsp/i386/pc386/include/edid.h: 4 * strange expression ?

Reported by: David Binderman Owned by: Needs Funding
Priority: normal Milestone: Indefinite
Component: bsps Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

1.

[src/c/src/lib/libbsp/i386/pc386/include/edid.h:455]: (style) Condition '3' is always true

Source code is

return (edid->RedYHigh<<2) | (edid->GreenRedLow?>>4)&&0x3;

Maybe better code

return (edid->RedYHigh<<2) | (edid->GreenRedLow?>>4) & 0x3;

2.

[src/c/src/lib/libbsp/i386/pc386/include/edid.h:458]: (style) Condition '3' is always true
[src/c/src/lib/libbsp/i386/pc386/include/edid.h:467]: (style) Condition '3' is always true
[src/c/src/lib/libbsp/i386/pc386/include/edid.h:470]: (style) Condition '3' is always true

Duplicates.

Change History (1)

comment:1 Changed on 01/24/17 at 06:33:08 by Sebastian Huber

Component: General → bsps
Milestone: 4.12 → Indefinite
Owner: set to Needs Funding
Status: new → assigned
Note: See TracTickets for help on using tickets.