#2709 assigned defect

comm/i386-stub.c:1025: possible missing break ?

Reported by: David Binderman Owned by: Needs Funding
Priority: normal Milestone: Indefinite
Component: unspecified Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

rtems/c/src/lib/libbsp/i386/shared/comm/i386-stub.c:1025] -> [rtems/c/src/lib/libbsp/i386/shared/comm/i386-stub.c:1029]: (warning) Variable 'reg' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

case '2':

reg = 1;

case '3':
case '4':
default:

Change History (4)

comment:1 Changed on Jan 19, 2017 at 8:49:28 PM by David Binderman

Still broken some eight months later.

comment:2 Changed on Jan 23, 2017 at 1:41:59 PM by Sebastian Huber

Milestone: 4.11.1Indefinite
Owner: set to Needs Funding
Status: newassigned

comment:3 Changed on Jan 23, 2017 at 3:12:30 PM by Joel Sherrill

As a comment for anyone who wants to pursue fixing this. This code is the target side of the remote debug stub for gdb. We copied this from somewhere else (likely gdb itself). I did a quick search for newer versions and found it in both the Android and Applen open source repositories.

My recommendation would be to update this by importing some more modern version and testing it.
GDB has added commands to the protocol and it is likely a newer version will already support them.

comment:4 Changed on Jan 23, 2017 at 10:44:48 PM by Chris Johns

The stub has a number of changes including hardware breakpoint support so a drop in needs a check of existing functionality. The BSP needs to be removed and changed to a 64bit x86 BSP.

Note: See TracTickets for help on using tickets.