![[RTEMS Logo]](/images/logo.png){kind=logo}
Opened on 05/14/16 at 15:22:29
Last modified on 01/23/17 at 22:44:48
#2709 assigned defect
comm/i386-stub.c:1025: possible missing break ?
| Reported by: | David Binderman | Owned by: | Needs Funding |
|---|---|---|---|
| Priority: | normal | Milestone: | Indefinite |
| Component: | unspecified | Version: | 4.10 |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: |
Description
rtems/c/src/lib/libbsp/i386/shared/comm/i386-stub.c:1025] -> [rtems/c/src/lib/libbsp/i386/shared/comm/i386-stub.c:1029]: (warning) Variable 'reg' is reassigned a value before the old one has been used. 'break;' missing?
Source code is
case '2':
reg = 1;
case '3':
case '4':
default:
Change History (4)
comment:1 Changed on 01/19/17 at 20:49:28 by David Binderman
comment:2 Changed on 01/23/17 at 13:41:59 by Sebastian Huber
| Milestone: | 4.11.1 → Indefinite |
|---|---|
| Owner: | set to Needs Funding |
| Status: | new → assigned |
comment:3 Changed on 01/23/17 at 15:12:30 by Joel Sherrill
As a comment for anyone who wants to pursue fixing this. This code is the target side of the remote debug stub for gdb. We copied this from somewhere else (likely gdb itself). I did a quick search for newer versions and found it in both the Android and Applen open source repositories.
My recommendation would be to update this by importing some more modern version and testing it.
GDB has added commands to the protocol and it is likely a newer version will already support them.
comment:4 Changed on 01/23/17 at 22:44:48 by Chris Johns
The stub has a number of changes including hardware breakpoint support so a drop in needs a check of existing functionality. The BSP needs to be removed and changed to a 64bit x86 BSP.
Still broken some eight months later.