Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

#2710 assigned defect

smsc9218i.c: 4 * Suspicious condition

Reported by: David Binderman Owned by: Needs Funding
Priority: normal Milestone: Indefinite
Component: unspecified Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

1.

rtems/c/src/lib/libbsp/powerpc/mpc55xxevb/network/smsc9218i.c:249]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses

Source code is

(busy = (regs->mac_csr_cmd & SMSC9218I_MAC_CSR_CMD_BUSY) != 0)

Maybe better code

((busy = (regs->mac_csr_cmd & SMSC9218I_MAC_CSR_CMD_BUSY)) != 0)

Some duplicates:

[rtems/c/src/lib/libbsp/powerpc/mpc55xxevb/network/smsc9218i.c:312]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses
rtems/c/src/lib/libbsp/powerpc/mpc55xxevb/network/smsc9218i.c:1556]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
rtems/c/src/lib/libbsp/powerpc/mpc55xxevb/network/smsc9218i.c:1791]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Change History (3)

comment:1 Changed on 01/20/17 at 15:18:18 by David Binderman

Still broken, some eight months later.

comment:2 Changed on 01/26/17 at 07:16:00 by Sebastian Huber

Milestone: 4.11.14.11.2

comment:3 Changed on 02/15/17 at 13:37:51 by Sebastian Huber

Milestone: 4.11.2Indefinite
Owner: set to Needs Funding
Status: newassigned
Note: See TracTickets for help on using tickets.