Opened on 01/15/22 at 00:47:50
Closed on 08/06/23 at 09:53:35
#4580 closed defect (fixed)
Update BSP for STM32H7
Reported by: | kgardas | Owned by: | Sebastian Huber |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | bsps | Version: | |
Severity: | normal | Keywords: | stm32h7 |
Cc: | Blocked By: | ||
Blocking: |
Description
It looks like after STM32H7 BSP was added STM added few more members to the stm32h7 chip family. So code addition tracked by #3910 is now a bit incomplete and it would be great to grab what was grabbed in the past and merge again since both projects https://github.com/STMicroelectronics/stm32h7xx_hal_driver and https://github.com/STMicroelectronics/STM32CubeH7 are up to date with latest hardware offerings from STM.
Anyway, when I tried to do merge myself I've found several things which may be considered difficult for merge:
(1) both projects seems to switch t o Unix line endings while original bsp submission kept original (of that time) DOS line endings.
(2) STM changed license note in the code itself:
- @endverbatim - ****************************************************************************** - * @attention - * - * <h2><center>© Copyright (c) 2017 STMicroelectronics. - * All rights reserved.</center></h2> - * - * This software component is licensed by ST under BSD 3-Clause license, - * the "License"; You may not use this file except in compliance with the - * License. You may obtain a copy of the License at: - * opensource.org/licenses/BSD-3-Clause - * - ****************************************************************************** - */ - + ****************************************************************************** + * @attention + * + * Copyright (c) 2017 STMicroelectronics. + * All rights reserved. + * + * This software is licensed under terms that can be found in the LICENSE file + * in the root directory of this software component. + * If no LICENSE file comes with this software, it is provided AS-IS. + *
Anyway, the new code adds support for following chips:
bsps/arm/stm32h7/include/stm32h723xx.h bsps/arm/stm32h7/include/stm32h725xx.h bsps/arm/stm32h7/include/stm32h730xx.h bsps/arm/stm32h7/include/stm32h730xxq.h bsps/arm/stm32h7/include/stm32h733xx.h bsps/arm/stm32h7/include/stm32h735xx.h bsps/arm/stm32h7/include/stm32h745xg.h bsps/arm/stm32h7/include/stm32h747xg.h
and also for Cordic and FMAC features whatever that means.
Change History (7)
comment:1 Changed on 01/15/22 at 00:51:37 by kgardas
comment:2 Changed on 02/06/22 at 22:13:47 by kgardas
As per Sebastian request here: https://lists.rtems.org/pipermail/devel/2022-January/070320.html -- I've updated HAL and reapplied necessary patches (those removed by files update) and fixed possible rejects by hand except the patch:
`
commit fe58f6ce4bf1ff5e92d64b9fee0cb46b6ac06e64
Author: Sebastian Huber <sebastian.huber@…>
Date: Thu Nov 26 08:13:52 2020 +0100
bsp/stm32h7: Add and use BSP Doxygen group
Update #3910.
`
on which I've started working on solving rejects just to notice after several files that even if I add all necessary groups, then still there are more added by HAL update and the tree will still not be complete with the change. Hence I left it without the patch completely in an idea that embedded-brains probably do have some script which updates those docygen directives.
Anyway, update hal project is here: https://github.com/kgardas/rtems -- and the branch is stm32h7-hal-update
Sebastian, I hope you don't mind if I reassign to you now for review. Thanks!
comment:3 Changed on 02/06/22 at 22:14:29 by kgardas
Owner: | set to Sebastian Huber |
---|---|
Status: | new → assigned |
comment:4 Changed on 02/07/22 at 06:24:39 by Sebastian Huber
Thanks for the update, I am very busy this week. Reviewing the patches needs a bit of time. Please ping me if you don't get feedback by mid of next week.
The license text in the in the ticket is an issue. Please make sure the LICENSE file is included in the branch in "the root directory of this software component". If the root directory is not clear, then this needs to be discussed on the mailing list. If it is a standard license, then an SPDX License Identifier should be added to the files.
comment:5 Changed on 02/07/22 at 20:56:58 by kgardas
My proposed LICENSE file for the bsps/arm/stm32h7 subdirectory is:
Files in this subdirectory which are copyrighted by STMicroelectronics are provided with either BSD-3-Clause or Apache License 2.0 license. The license in use depends on the origin of the particular file in question. Files here come from two projects: stm32h7xx_hal_driver located on: https://github.com/STMicroelectronics/stm32h7xx_hal_driver.git STM32CubeH7 located on: https://github.com/STMicroelectronics/STM32CubeH7.git Files coming from STM32CubeH7 project which are listed in explicit list below are provided with Apache License 2.0. Apache License 2.0 file list: stm32h723xx.h stm32h725xx.h stm32h730xx.h stm32h730xxq.h stm32h733xx.h stm32h735xx.h stm32h742xx.h stm32h743xx.h stm32h745xg.h stm32h745xx.h stm32h747xg.h stm32h747xx.h stm32h750xx.h stm32h753xx.h stm32h755xx.h stm32h757xx.h stm32h7a3xx.h stm32h7a3xxq.h stm32h7b0xx.h stm32h7b0xxq.h stm32h7b3xx.h stm32h7b3xxq.h stm32h7xx.h system_stm32h7xx.h system_stm32h7xx.c All other files here copyrighted by STMicroelectronics come from stm32h7xx_hal_driver project and are provided with BSD-3-Clause license below. Copyright 2017 STMicroelectronics. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
I'll try to draw Joel's or Gedare attention to this to get some wording fixes and review of it.
comment:6 Changed on 02/07/22 at 21:51:00 by kgardas
Sebastian, I've created LICENSE in bsps/arm/stm32h7 with the content above reviewed by Joel. It's already in the branch on github.com waiting for your next week review.
comment:7 Changed on 08/06/23 at 09:53:35 by kgardas
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This is duplicate and fixed as part of #4934.
I've found out that using
git diff -b
may help with (1) problem to review update changes ignoring line ends changes. Still the diff itself is about 117k lines of code so quite heavy to push thorough email I would guess.