Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

Opened on 03/04/21 at 15:03:12

Closed on 03/05/21 at 20:20:23

#4294 closed defect (fixed)

satcan.c: Unsigned compared against 0 error spotted by Coverity

Reported by: Ryan Long Owned by: Ryan Long <ryan.long@…>
Priority: normal Milestone: 6.1
Component: bsps Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

CID 1399768: Unsigned compared against 0 in satcan_ioctl().

303                DBG("SatCAN: ioctl: masking register %d, with value %x\n\r",
304                    regmod->reg, regmod->val);
   unsigned_compare: This less-than-zero comparison of an unsigned value is never true. regmod->reg < 0U.
305                if (regmod->reg < 0)
306                        return RTEMS_INVALID_NAME;
307                else if (regmod->reg <= SATCAN_FILTER_STOP)

Change History (1)

comment:1 Changed on 03/05/21 at 20:20:23 by Ryan Long <ryan.long@…>

Owner: set to Ryan Long <ryan.long@…>
Resolution: → fixed
Status: new → closed

In [changeset:"1f29ee4528290cd516be551c0ff7e945d6567390/rtems" 1f29ee4/rtems]:

Error: Processor CommitTicketReference failed
/data/trac/repo/rtems.git does not appear to be a Git repository.
Note: See TracTickets for help on using tickets.