src/c/src/lib/libbsp/arm/raspberrypi/i2c/i2c.c:320: defective error checking ?

[David Binderman]

src/c/src/lib/libbsp/arm/raspberrypi/i2c/i2c.c:320]: (style) Checking if unsigned variable 'rv' is less than zero.

Source code is

rv = rpi_i2c_setup_transfer(bus);

if ( rv < 0 ) {

but

uint32_t rv = 0;

and

static int rpi_i2c_setup_transfer(rpi_i2c_bus *bus)

Suggest put return value into an int local variable, then
sanity check it, then assign it to rv.

[Gedare Bloom <gedare@…>]

In [changeset:"70e8abf3917c93ab085ca77fee379df9fa000183/rtems"]:

raspberrypi: use signed int for return variable

Closes #2873.

[Joel Sherrill]

This ticket is closed but I would like to know what you are running to spot these issues and what settings.

I would like to make sure that eventually we are running the same thing as a project. I would have emailed directly but couldn't find your email.

Thanks.

--joel

[David Binderman]

I would like to know what you are running to spot these issues and what settings.

I run a static C / C++ analyser called cppcheck, available from sourceforge.

​http://cppcheck.sourceforge.net/

The latest released version would probably work ok, but I use the current development version.
I use flag --enable=all and I've tweeked the source of cppcheck as well.

BTW, if I could figure out how to build rtems on Linux, then I could run the latest
development versions of clang and gcc over rtems and possibly get some interesting warnings.

I would like to make sure that eventually we are running the same thing as a project.

I have been doing this myself for about a year or so. I'd be more than happy
to help and share my results.

I would have emailed directly but couldn't find your email.

dcb 314 at hotmail dot com. Feel free to chat offline.

[Sebastian Huber]

Milestone renamed