Fix exclude rule in rtems-test-check

[Stavros Passas]

rtems-test-check is responsible of checking the testsuite configuration of a given BSP and adapt it based on a given "command". Currently for the "exclude" command, we never exclude anything, the output of the script is always the whole list of the input tests.

This happens because the script always starts with output = $tests and appends on the list the tests that are not excluded, so the output is always all the tests.

[Stavros Passas]

proposed fix

[Stavros Passas]

I attached a simple fix that would solve the described issue. The issue is created because we want to provide a full list of tests in case the exclude file from the BSP is non-existing, thus a simple fix would be to start with an empty list if the BSP file exists, or with a full list there is nothing to exclude.

[Joel Sherrill]

Thanks. I had reported that a LOT of BSPs failed to complete building all tests but hadn't tracked it down completely. I am testing this patch. Does it look OK?

index e02f8e9..218d1f0 100755
--- a/tools/build/rtems-test-check
+++ b/tools/build/rtems-test-check
[joel@rtbf64c rtems]$ git diff tools/
diff --git a/tools/build/rtems-test-check b/tools/build/rtems-test-check
index e02f8e9..218d1f0 100755
--- a/tools/build/rtems-test-check
+++ b/tools/build/rtems-test-check
@@ -32,7 +32,7 @@ done

case ${mode} in

exclude)

• output=${tests}

+ output=

;;

flags)

if [ $test_count != 1 ]; then

[Stavros Passas]

Hi Joel, no this will not work, because for the BSPs that do not have an exclude testsuite list, the output will be returned immediately as ${output} (that will be ""), and the BSP will not compile any test!

[Joel Sherrill]

Unfortunately, it looks like this script has grown complicated enough where some test cases are needed that are independent of the BSPs and testsuite.

I will try to look at it some more but am assigning this to Chris since he wrote the script.

[Joel Sherrill]

I posted a patch to devel which works for gensh1 (has .tcfg file with excludes) and pc686 which doesn't have a .tcfg file. I will build all BSPs before I consider pushing this.

Feedback appreciated.

[Joel Sherrill]

I have built all BSPs with your patch and my additions to some .tcfg files.

The only BSPs with build issues are those which are gcc < 5.0 due to using restrict and not restrict in devctl.h. This is fixed in newlib and the next newlib snapshot and tool bump will fix those.

Reopen if you think this isn't OK.

[Sebastian Huber]

Milestone renamed