Opened on 07/25/16 at 15:54:29

Last modified on 02/15/17 at 13:44:44

#2766 assigned defect

/src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891: code and comment don't match ?

Reported by: David Binderman Owned by: Needs Funding
Priority: normal Milestone: Indefinite
Component: unspecified Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

rtems/c/src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891]: (style) Same expression on both sides of '|'

Source code is

/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_FMPI2C_DISABLE_IT(hfmpi2c,FMPI2C_IT_ERRI | FMPI2C_IT_TCI| FMPI2C_IT_STOPI| FMPI2C_IT_NACKI | FMPI2C_IT_ADDRI | FMPI2C_IT_RXI | FMPI2C_IT_RXI );

Maybe better code

/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_FMPI2C_DISABLE_IT(hfmpi2c,FMPI2C_IT_ERRI | FMPI2C_IT_TCI| FMPI2C_IT_STOPI| FMPI2C_IT_NACKI | FMPI2C_IT_ADDRI | FMPI2C_IT_RXI | FMPI2C_IT_TXI );

Change History (2)

comment:1 Changed on 01/26/17 at 07:16:00 by Sebastian Huber

Milestone: 4.11.1 → 4.11.2

comment:2 Changed on 02/15/17 at 13:44:44 by Sebastian Huber

Milestone: 4.11.2 → Indefinite
Owner: set to Needs Funding
Status: new → assigned
Note: See TracTickets for help on using tickets.