#2420 assigned defect

RSB %source file fails

Reported by: Jakob Viketoft Owned by: Chris Johns
Priority: normal Milestone: 5.1
Component: tool/rsb Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

It seems that the method for accessing an existing file repository both isn't covered much in the "manual", but it also fails to find it. Looking at the python code in download.py, it requires the format file:// to identify the local file protocol, but then tries to access the actual file/directory using that the entire url (including file://).

This unfortunately fails and I'm not familiar enough with Python to correct this, although it appears that the "file://" part should be cut from the URL before calling the "return path.isdir(url)" in the _file_downloader function.

Change History (8)

comment:1 Changed on Sep 14, 2015 at 2:03:57 PM by Gedare Bloom

Owner: set to Chris Johns
Status: newassigned
Version: 4.104.11

comment:2 Changed on Sep 14, 2015 at 2:05:11 PM by Gedare Bloom

Can you provide some more information about the failure? What are you trying to build, what is the config/bset being used, what %source directive fails? It may help to attach the log

comment:3 Changed on Sep 15, 2015 at 8:45:29 AM by Jakob Viketoft

Well, at the moment I'm chasing a build bug in newlib and have modified a bset to allow me to change the source code locally. This was a perfect match for the "file" type available for %source, but as I stated it doesn't seem to work completely. (I would also like to use it later to have git sources as submodules instead of cloned-on-demand.)

E.g., if I use a bset and modify the %source path for newlib from e.g. git:// to file:///full_path_to_this_dir/sources/git/newlib it doesn't find the directory. I added a printout of the url variable in _file_downloader in download.py, and the url contains the full given address as file:///full_path_to_this_dir/sources/git/newlib. This is then given to path.isdir and predictably fails.

Or am I missing something fundamental here?

comment:4 Changed on Sep 15, 2015 at 11:54:47 PM by Chris Johns

There maybe a bug in the 'file' implementation, but I think what you are asking for is something new. I think you are asking to use the source tree as is in the location it is and to build using it where the 'file' expects a tar type file. Using the source in the specified location is currently not implemented. It is an interesting feature to add and I like it. It however would require I take a look to see what it effects and currently time is limited.

comment:5 Changed on Jan 26, 2017 at 7:16:00 AM by Sebastian Huber

Milestone: 4.11.14.11.2

comment:6 Changed on Mar 22, 2017 at 11:58:33 PM by Chris Johns

Milestone: 4.11.24.12
Version: 4.114.12

This is a new feature and not suitable on a release branch.

comment:7 Changed on May 11, 2017 at 7:31:02 AM by Sebastian Huber

Milestone: 4.124.12.0

comment:8 Changed on Nov 9, 2017 at 6:27:14 AM by Sebastian Huber

Milestone: 4.12.05.1

Milestone renamed

Note: See TracTickets for help on using tickets.