Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

Opened on 02/02/12 at 15:47:23

Closed on 02/02/12 at 18:25:53

#2011 closed defect (fixed)

GRETH: potential deadlock, one bugfix, performance improvements

Reported by: Daniel Hellstrom Owned by: Eric Norum
Priority: normal Milestone: 4.11
Component: network/legacy Version: 4.11
Severity: normal Keywords:
Cc: joel.sherrill@… Blocked By:
Blocking:

Description

GRETH: Moved print to remove potential deadlock

Deadlock may arise when the EDCL bug link is used to tunnel
console output over Ethernet, when Ethernet is down one should
avoid using console (only during debugging of LEON targets)

Author: Marko Isomaki <marko@…>
Signed-off-by: Daniel Hellstrom <daniel@…>

c/src/libchip/network/greth.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)

GRETH: performance improvements and one bugfix

GRETH driver updated, 10-15% performance improvements for GBIT MAC,
unnecessary RX interrupts not taken which under heavy load saves approx.
1500 interrupts/s, one task removed saving about 5kb memory and 1 bug
solved.

BUG: RX interrupt was enabled before the RX-daemon was created which could
result in a faulty call to rtems_event_send.

Signed-off-by: Daniel Hellstrom <daniel@…>

c/src/libchip/network/greth.c | 497 ++++++++++++++++++++++++++---------------
1 files changed, 317 insertions(+), 180 deletions(-)

Attachments (2)

0007-GRETH-Moved-print-to-remove_HEAD.patch​ (2.4 KB) - added by Daniel Hellstrom on 02/02/12 at 15:47:23.
patch1 for HEAD
0008-GRETH-performance-improvements_HEAD.patch​ (24.2 KB) - added by Daniel Hellstrom on 02/02/12 at 15:48:42.
patch2 for HEAD

Download all attachments as: .zip

Change History (5)

Changed on 02/02/12 at 15:47:23 by Daniel Hellstrom

Attachment: 0007-GRETH-Moved-print-to-remove_HEAD.patch​ added

patch1 for HEAD

Changed on 02/02/12 at 15:48:42 by Daniel Hellstrom

Attachment: 0008-GRETH-performance-improvements_HEAD.patch​ added

patch2 for HEAD

comment:1 Changed on 02/02/12 at 15:49:24 by Daniel Hellstrom

Cc: Joel Sherrill added

comment:2 Changed on 02/02/12 at 18:25:53 by Joel Sherrill

Resolution: → fixed
Status: new → closed

Applied to 4.10 branch and head.

Closing.

comment:3 Changed on 11/24/14 at 18:58:28 by Gedare Bloom

Version: HEAD → 4.11

Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11

Note: See TracTickets for help on using tickets.