![[RTEMS Logo]](/images/logo.png){kind=logo}
Opened on 04/13/11 at 16:42:12
Closed on 04/22/11 at 12:28:36
#1777 closed defect (fixed)
Accessing _Thread_Dispatch_disable_level should be consolidated
| Reported by: | Jennifer Averett | Owned by: | Joel Sherrill |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.11 |
| Component: | score | Version: | 4.11 |
| Severity: | normal | Keywords: | |
| Cc: | sebastian.huber@…, gedare@… | Blocked By: | |
| Blocking: |
Description
In order to support future SMP work _Thread_Dispatch_disable_level should only be touched by a handful of routines. The attached patch adds the inline routines:
_Thread_Dispatch_in_critical_section(),
_Thread_Dispatch_get_disable_level(),
_Thread_Dispatch_set_disable_level(),
_Thread_Dispatch_increment_disable_level() and
_Thread_Dispatch_decrement_disable_level().
Where possible the source has been modified to call one of these routines instead of directly accessing _Thread_Dispatch_disable_level.
Additionally, _Thread_Disable_dispatch and _Thread_Enable_dispatch were made inline only when not SMP or the heavy debug was turned on. Otherwise, the routines defined in the new files threaddisabledispatch.c and threadenabledispatch.c are used.
Attachments (2)
Change History (7)
Changed on 04/13/11 at 16:42:12 by Jennifer Averett
| Attachment: | DispatchPatch.diff added |
|---|
comment:1 Changed on 04/14/11 at 18:25:26 by Gedare Bloom
| Cc: | giddyup44@… added |
|---|
comment:2 Changed on 04/15/11 at 05:29:05 by Sebastian Huber
| Cc: | Sebastian Huber added |
|---|
Changed on 04/15/11 at 13:26:25 by Jennifer Averett
| Attachment: | DispatchPatch_v1.diff added |
|---|
consolidate access to _Thread_Dispatch_disable_level
comment:3 Changed on 04/15/11 at 13:26:25 by Jennifer Averett
| attachments.isobsolete: | 0 → 1 |
|---|
comment:4 Changed on 04/22/11 at 12:28:36 by Jennifer Averett
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Modifications Merged.
comment:5 Changed on 11/24/14 at 18:58:28 by Gedare Bloom
| Version: | HEAD → 4.11 |
|---|
Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11
consolidate access to _Thread_Dispatch_disable_level