![[RTEMS Logo]](/images/logo.png){kind=logo}
Opened on 03/10/11 at 08:54:13
Closed on 01/22/15 at 21:19:17
#1761 closed enhancement (fixed)
2kB of memory are lost in the SpaceWire Driver
| Reported by: | Cláudio Silva | Owned by: | Daniel Hellstrom |
|---|---|---|---|
| Priority: | highest | Milestone: | 4.11 |
| Component: | bsps | Version: | 4.10 |
| Severity: | minor | Keywords: | |
| Cc: | joel.sherrill@…, cynt6007@… | Blocked By: | |
| Blocking: |
Description (last modified by Gedare Bloom)
The structure GRSPW_DEV has two members that are the Descriptor Tables
used for the DMA engines. These members are allocated statically (char
_txtable[SPACEWIRE_BDTABLE_SIZE*2]; ) with twice the size they need
to be. They should have 1024 bytes of size and have 2048. This extra
size is needed because the descriptor table needs to be 1024 aligned
(0x400).
In the function grspw_hw_init these memory areas are passed to the
function SPW_ALIGN which returns the first aligned address in the
memory area. This way the driver is allocating twice the memory
needed in order to find an aligned base address for the table inside
the memory area.
For example if the _txtable start address is 0x40000001, the address
returned by SPW_ALIGN will be 0x40000400 and the used memory area
will be 0x40000400-0x40000800. Addresses in the range 0x80000001-
0x40000399 will not be used, but will remain allocated.
This way we are losing 2kB in the descriptor tables.
Attachments (2)
Change History (10)
comment:1 Changed on 03/10/11 at 08:57:27 by Cláudio Silva
| Owner: | changed from Joel Sherrill to Chris Johns |
|---|
comment:2 Changed on 03/10/11 at 14:46:13 by Joel Sherrill
| Cc: | Joel Sherrill added |
|---|
Changed on 12/16/13 at 00:40:34 by Daniel Ramirez
| Attachment: | grspw.patch added |
|---|
Changed on 12/16/13 at 18:39:05 by Daniel Ramirez
| Attachment: | grspw-2.patch added |
|---|
Desciptor tables no longer statically allocated
comment:3 Changed on 12/16/13 at 18:39:05 by Daniel Ramirez
| attachments.isobsolete: | 0 → 1 |
|---|
comment:4 Changed on 01/08/14 at 04:49:13 by cynt6007
| Status: | new → assigned, cynt6007@vandals.uidaho.edu |
|---|
comment:5 Changed on 11/23/14 at 17:37:45 by Joel Sherrill
| Description: | modified (diff) |
|---|---|
| Owner: | changed from Chris Johns to Daniel Hellstrom |
comment:6 Changed on 12/19/14 at 05:06:18 by Gedare Bloom
| Priority: | normal → highest |
|---|
Bump priority to highest for tickets with a fix attached or seemingly simple fix proposed in the description or comments.
comment:7 Changed on 01/22/15 at 21:18:33 by Gedare Bloom
| Description: | modified (diff) |
|---|
Fixed by [changeset:2486c49/rtems]
comment:8 Changed on 01/22/15 at 21:19:17 by Gedare Bloom
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Descriptor tables are no longer statically allocated, saving memory