arm/csb336/network/lan91c11x.c: array subscript is above array bounds

[Ralf Corsepius]

Using very aggressive warning flags on rtems-4.10/rtems-CVS, exposes this bug:

arm-rtems4.10-gcc --pipe -B../../../../../.././lib/
-B../../../../../.././csb336/lib/ -specs bsp_specs -qrtems -DHAVE_CONFIG_H
-isystem ../../../../../.././csb336/lib/include -DINSIDE_RTEMS_BSD_TCPIP_STACK
-Wall -Wimplicit-function-declaration -Wstrict-prototypes -Wnested-externs -ansi -fasm -mcpu=arm920 -mstructure-size-boundary=8

-O2 -g -MT network_rel-lan91c11x.o -MD -MP -MF .deps/network_rel-lan91c11x.Tpo -c

-o network_rel-lan91c11x.o test -f 'network/lan91c11x.c' || echo '../../../../../../../../../rtems.work/c/src/lib/libbsp/arm/csb336/'network/lan91c11x.c
../../../../../../../../../rtems.work/c/src/lib/libbsp/arm/csb336/network/lan91c11x.c: In function 'lan91c11x_write_phy_reg':
../../../../../../../../../rtems.work/c/src/lib/libbsp/arm/csb336/network/lan91c11x.c:228: warning: array subscript is above array bounds
mv -f .deps/network_rel-lan91c11x.Tpo .deps/network_rel-lan91c11x.Po

GCC's warning is right.

The location it warns about, expands to
bits[64] = ...
which is "one index beyon array bounds" (bit[64]).

Unfortunately, I don't understand enough about this piece of code to be able to fix it.

Affected: rtems-4.8, 4.9 and 4.10

[Joel Sherrill]

Proposed patch

[Joel Sherrill]

Patch #2

[Joel Sherrill]

Patch applied to 4.8 branch, 4.9 branch and CVS head.