Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

Opened on 09/03/08 at 14:08:37

Closed on 09/03/08 at 19:30:30

Last modified on 09/03/08 at 21:02:18

#1305 closed defect (wontfix)

c/src/lib/libbsp/powerpc/score603e/console/consolebsp.h: volatile boolean

Reported by: Ralf Corsepius Owned by: Joel Sherrill
Priority: normal Milestone: 4.9
Component: bsps Version: 4.9
Severity: major Keywords:
Cc: Blocked By:
Blocking:

Description

Another case of an obscure volatile boolean
c/src/lib/libbsp/powerpc/score603e/console/consolebsp.h:
...

volatile rtems_boolean Is_TX_active;

...

IMO, this volatile is wrong and should be removed.

cf. http://www.rtems.org/bugzilla/show_bug.cgi?id=1300

Change History (2)

comment:1 Changed on 09/03/08 at 19:30:30 by Joel Sherrill

Resolution: → wontfix
Status: new → closed

comment:2 Changed on 09/03/08 at 21:02:18 by Ralf Corsepius

Replying to comment:1:

This looks like a valid use of a volatile bool to me.

Looks like a poor man's mutex to me ;)

It indicates whether or
not the hardware transmitter is currently transmitting a character and thus
could be changed at task or ISR level.

Interprocess communication by passing the address of a local variable?

Note: See TracTickets for help on using tickets.