Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

Opened on 05/21/19 at 15:43:26

Closed on 12/19/19 at 07:57:47

#3753 closed defect (fixed)

Rename CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS

Reported by: Joel Sherrill Owned by: Sebastian Huber <sebastian.huber@…>
Priority: normal Milestone: 5.1
Component: config Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS probably should not mention LIBIO as that is an internal component/organization aid which should not be visible to the user.

This ticket is to discuss renaming CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS to just CONFIGURE_MAXIMUM_FILE_DESCRIPTORS.

Perhaps deprecate now and obsolete in next major version. Include code to warn and map old name to new.

Thoughts?

Change History (5)

comment:1 Changed on 05/22/19 at 05:45:29 by Sebastian Huber

I like CONFIGURE_MAXIMUM_FILE_DESCRIPTORS better, however, do we really want to tinker with this configuration option which is used probably in hundreds of application configurations? It will probably force users to do something like this

#if RTEMS_VERSION >= 5
#define CONFIGURE_MAXIMUM_FILE_DESCRIPTORS X
#else
#define CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS X
#endif

comment:2 Changed on 12/12/19 at 23:30:31 by Chris Johns

Sebastian, can this be worked on while you are playing with the config?

comment:3 Changed on 12/13/19 at 06:04:11 by Sebastian Huber

Yes, I work on this. I hope to finish the configuration related stuff by end of next week.

comment:4 Changed on 12/19/19 at 07:55:54 by Sebastian Huber <sebastian.huber@…>

In [changeset:"3cec2dfbc427db269c1d2de5a235723886b516e2/rtems" 3cec2df/rtems]:

config: CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS

Rename CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS into
CONFIGURE_MAXIMUM_FILE_DESCRIPTORS.

Update #3753.

comment:5 Changed on 12/19/19 at 07:57:47 by Sebastian Huber <sebastian.huber@…>

Owner: set to Sebastian Huber <sebastian.huber@…>
Resolution: → fixed
Status: new → closed

In [changeset:"2c58b5f9960fae61b4f76b562b4dcf8ec1f1f37f/rtems-docs" 2c58b5f/rtems-docs]:

c-user: CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS

Rename CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS in
CONFIGURE_MAXIMUM_FILE_DESCRIPTORS.

Close #3753.

Note: See TracTickets for help on using tickets.