Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

#1269 closed defect (fixed)

[libblock] rtems_disk_io_done releases semaphore instead of deleting

Reported by: strauman Owned by: Joel Sherrill
Priority: normal Milestone: 4.7
Component: lib/block Version: 4.7
Severity: normal Keywords:
Cc: chrisj@…, victor.vengerov@… Blocked By:
Blocking:

Description

It seems to me that the purpose of 'rtems_disk_io_done()'
is cleaning up resources allocated by rtems_disk_io_initialize().

However, rtems_disk_io_done() releases the 'diskdevs_mutex' semaphore that
was created by rtems_disk_io_initialize() instead of deleting it.

(Note that there is no rtems_semaphore_obtain() call that would
match the rtems_semaphore_release())

Attachments (1)

diskdevs.c.diff (657 bytes) - added by strauman on 01/05/08 at 23:26:14.
patch

Download all attachments as: .zip

Change History (4)

Changed on 01/05/08 at 23:26:14 by strauman

Attachment: diskdevs.c.diff added

patch

comment:1 Changed on 01/05/08 at 23:26:59 by strauman

Summary: rtems_disk_io_done releases semaphore instead of deleting[libblock] rtems_disk_io_done releases semaphore instead of deleting

comment:2 Changed on 08/06/08 at 03:05:14 by Chris Johns

Cc: Chris Johns added
Resolution: fixed
Status: newclosed

Change committed to CVS.

comment:3 Changed on 10/10/17 at 06:49:52 by Sebastian Huber

Component: scorelib/block
Note: See TracTickets for help on using tickets.