#500 closed defect (fixed)

Termios tty->buf overflow correction

Reported by: cedric_aubert Owned by: Eric Norum
Priority: normal Milestone: 4.9
Component: unspecified Version: 4.6
Severity: major Keywords:
Cc: bugs@…, joel.sherrill@…, chrisj@… Blocked By:
Blocking:

Description

Evenif you will have hardware flowcontrol enable,
you will have some overflow in interrupt mode.
Flow control can avoid
overflow of raw_inbuf but don't care of tty->buf, and
fillbufferQueue don't care about tty->buf size. Just
care about this size in fillbufferqueue avoid of
this overflow.

Disable interrupt in fillBufferQueue() before modify
tty->flow_ctrl. It could have some trouble when
you are at lowwater and if some serial interrupt come
on fill the buffer and ask to stopremotetx. They only
happend in low performance cpu.

Release:
RTEMS-4.6

How-To-Repeat:
Just transfert a big file with overflow enable, you will
lose many character.

Attachments (2)

Termios.diff (463 bytes) - added by cedric_aubert on Dec 3, 2006 at 1:31:13 PM.
Termios.diff
Patch_rtems-4.6.0_cpukit_libcsupport_src_termios_c.diff (1.4 KB) - added by cedric_aubert on Dec 3, 2006 at 1:31:13 PM.
Patch_rtems-4.6.0_cpukit_libcsupport_src_termios_c.diff

Download all attachments as: .zip

Change History (8)

comment:1 Changed on Sep 26, 2003 at 4:44:12 PM by Joel Sherrill

Owner: changed from joel to eric

comment:2 Changed on Feb 18, 2004 at 4:32:33 AM by Chris Johns

Owner: changed from eric to Chris Johns

comment:3 Changed on Sep 1, 2005 at 2:01:39 PM by Joel Sherrill

Owner: changed from Chris Johns to eric

comment:4 Changed on Sep 8, 2006 at 7:46:18 PM by Joel Sherrill

Status: assignedwaiting

Changed on Dec 3, 2006 at 1:31:13 PM by cedric_aubert

Attachment: Termios.diff added

Termios.diff

comment:5 Changed on Aug 5, 2008 at 4:16:13 PM by Joel Sherrill

Milestone: 4.9
rep_platform: All

comment:6 Changed on Aug 19, 2008 at 7:28:44 PM by Joel Sherrill

Resolution: fixed
Status: assignedclosed

Patch committed on all branches needing it.

comment:7 Changed on Oct 10, 2017 at 6:35:44 AM by Sebastian Huber

Component: miscunspecified
Note: See TracTickets for help on using tickets.