realloc deallocates argument pointer if new_area cannot be obtained

[kamen]

Accordingly to "C Reference Manual", p. 388, documentation of realloc:

"If the request cannot be satisfied, a null pointer is returned and the old region is not disturbed."

However, the RTEMS definition of realloc contains this:

---

new_area = malloc( size );

MSBUMP(malloc_calls, -1); /* subtract off the malloc */

if ( !new_area ) {

free( ptr );
return (void *) 0;

}

---

free( ptr ) is erroneous and should be removed.

Release:
RTEMS-4.5 ss20030417

Environment:
host = Cygwin
target = powerpc

How-To-Repeat:
Allocate an array and keep growing it with realloc until realloc fails.

[Joel Sherrill]

State-Changed-From-To: open->closed
State-Changed-Why: Fix in 4.6 branch and trunk. The Open Group Single UNIX

Specificatoin also defines the same behavior. I added a
comment indicating that this really was the desired behavior
so someone in the future won't be tempted to add it again.

[kamen]

pr479.diff