Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

#4751 closed defect (fixed)

chmod problem in shell of RTEMS 6

Reported by: chenjin_zhong Owned by: Chris Johns
Priority: normal Milestone: 6.1
Component: shell Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

Cloned from #4558:


Hi, I find one problem in rtems_shell_main_chmod function. the usage of this instruction is descripted as "chmod 0777 n1 n2... #change filemode", .the src code is listed as follows. the bold part should be replaced with chmod(argv[n], mode)?

static int rtems_shell_main_chmod(
  int argc,
  char *argv[]
)
{
  int           n;
  mode_t        mode;
  unsigned long tmp;

  if (argc < 2) {
    fprintf(stderr,"%s: too few arguments\n", argv[0]);
    return -1;
  }

  /*
   *  Convert arguments into numbers
   */
  if ( rtems_string_to_unsigned_long(argv[1], &tmp, NULL, 0) ) {
    printf( "Mode argument (%s) is not a number\n", argv[1] );
    return -1;
  }
  mode = (mode_t) (tmp & 0777);

  /*
   *  Now change the files modes
   */
  for (n=2 ; n < argc ; n++)
    chmod(argv[n++], mode); /* <<<< here */

  return 0;
}

Change History (2)

comment:1 Changed on 11/30/22 at 00:05:18 by Chris Johns

Owner: set to Chris Johns
Status: newassigned

comment:2 Changed on 12/26/22 at 19:37:09 by zack leung <zakthertemsdev@…>

Resolution: fixed
Status: assignedclosed

In [changeset:"c8c713c6bdd73aa1d491f0f42bb5236e927e5f03/rtems" c8c713c/rtems]:

rtems_shell_main_chmod: Correct argument indexing

Closes #4751

Note: See TracTickets for help on using tickets.