Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

#4569 closed defect (fixed)

aarch64 cache support does not provide rtems_cache_disable_data()

Reported by: Sebastian Huber Owned by: Joel Sherrill
Priority: normal Milestone: 6.1
Component: arch/aarch64 Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

The aarch64 cache support defines:

bsps/aarch64/shared/cache/cache.c:#define CPU_CACHE_SUPPORT_PROVIDES_DISABLE_DATA

However, it does not provide rtems_cache_disable_data().

Change History (2)

comment:1 Changed on 12/10/21 at 15:31:20 by Kinsey Moore

You are correct, while the AArch64 cache code provides _CPU_cache_disable_data(), it does not provide rtems_cache_disable_data(). I'll submit a patch to remove this define since the existing support via _CPU_cache_disable_data should be sufficient given that CPU_DATA_CACHE_ALIGNMENT is defined.

comment:2 Changed on 12/12/21 at 17:58:14 by Kinsey Moore <kinsey.moore@…>

Resolution: fixed
Status: assignedclosed

In [changeset:"68b0db358c81a7f770a44ceb819197bdc320bc99/rtems" 68b0db35/rtems]:

bsps/aarch64: Remove erroneous cache feature

The AArch64 cache implementation does not define
rtems_cache_disable_data(), but declares that it does via
CPU_CACHE_SUPPORT_PROVIDES_DISABLE_DATA. The existing implementation of
_CPU_cache_disable_data() is sufficient to enable this functionality
without the erroneous cache feature flag.

Closes #4569

Note: See TracTickets for help on using tickets.