Opened on 05/05/21 at 14:00:34

Closed on 05/10/21 at 16:47:35

#4402 closed defect (fixed)

rtemstoolkit/mailer.py option added twice

Reported by: Alex White Owned by: Alex White
Priority: normal Milestone: 6.1
Component: tool Version: 6
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

In the add_arguments function, the intent is that the first two options are added to the arguments before the rest of them are iterated and added. The iteration of the remaining options, however, starts with the first option when it should start with the second.

Additionally, the order of keys in a dictionary cannot be relied on for all versions of Python we support. The dictionary should be changed to an OrderedDict to preserve key order to facilitate iteration.

Change History (2)

comment:1 Changed on 05/05/21 at 14:00:46 by Alex White

Owner: set to Alex White
Status: new → accepted

comment:2 Changed on 05/10/21 at 16:47:35 by Alex White <alex.white@…>

Resolution: → fixed
Status: accepted → closed

In f18e6d8/rtems-tools:

rtemstoolkit/mailer.py: Fix option ordering for add_arguments

The ordering of keys cannot be guaranteed in a dictionary. This changes
the options iteration to no longer rely on key ordering.

Closes #4402

Note: See TracTickets for help on using tickets.