#423 closed defect (invalid)

Shell doesn't check for a end of list when adding monitor commands

Reported by: mikeci Owned by: Joel Sherrill
Priority: lowest Milestone: 2
Component: unspecified Version: 4.6
Severity: normal Keywords:
Cc: bugs@…, ralf.corsepius@… Blocked By:


In cmds.c there is a bug. In function register_cmds when adding monitor commands the while loop should test for NULL string in the command field:

while(command->command) /* we need to check if command is a NULL string */

and not if command is a NULL pointer because the last entry in the monitor table is not NULL.

Also in the present form both files are unreadable. I applied C beautifier on them.


Change History (2)

comment:1 Changed on Jul 9, 2003 at 6:13:54 AM by Ralf Corsepius

Status: assignedclosed

State-Changed-From-To: open->closed
State-Changed-Why: Incomplete PR.

comment:2 Changed on Oct 10, 2017 at 6:35:44 AM by Sebastian Huber

Component: miscunspecified
Note: See TracTickets for help on using tickets.