Notice: We have migrated to GitLab launching 2024-05-01 see here:

#422 closed defect (fixed)

Shell doesn't check for a end of list when adding monitor commands

Reported by: mikeci Owned by: Joel Sherrill
Priority: lowest Milestone: 2
Component: unspecified Version: 4.6
Severity: normal Keywords:
Cc: bugs@… Blocked By:


In cmds.c there is a bug. In function register_cmds when adding monitor commands the while loop should test for NULL string in the command field:

while(command->command) /* we need to check if command is a NULL string */

and not if command is a NULL pointer because the last entry in the monitor table is not NULL.

Also in the present form both files are unreadable. I applied C beautifier on them.


Attachments (1) (10.5 KB) - added by mikeci on 12/03/06 at 13:31:13.

Download all attachments as: .zip

Change History (4)

comment:1 Changed on 08/22/03 at 17:57:20 by Joel Sherrill

Status: assignedwaiting

comment:2 Changed on 09/26/03 at 16:39:46 by Joel Sherrill

Status: waitingclosed

State-Changed-From-To: feedback->closed
State-Changed-Why: Assumed to be fixed by alternative patch in PR436.

Changed on 12/03/06 at 13:31:13 by mikeci

Attachment: added

comment:3 Changed on 10/10/17 at 06:35:44 by Sebastian Huber

Component: miscunspecified
Note: See TracTickets for help on using tickets.