#389 closed defect (fixed)

Doubts on cpukit/libcsupport/src/no_posix.c

Reported by: Ralf Corsepius Owned by: Joel Sherrill
Priority: lowest Milestone: 2
Component: score Version: 4.6
Severity: normal Keywords:
Cc: bugs@… Blocked By:
Blocking:

Description

Some doubts on cpukit/libcsupport/src/no_posix.c

  1. no posix.c uses

int _kill_r( pid_t pid, int sig ),

newlib's reent.h wants
int _kill_r( struct _reent *ptr, pid_t pid, int sig )

As _kill_r doesn't do anthing useful, this conflict probably
doesn't have any effect.

  1. _kill_r in no_posix.c is defined unconditionally, while

most *_r-functions in general are newlib specific.

_kill_r is not meaningful if not using newlib, so .. this also probably doesn't have any effect.

  1. no_posix.c includes <sys/reent.h>.

IMO, this is bogus, no_posix.c should include <reent.h> instead to get the prototypes of the *_r functions from newlib.

  1. the prototype of _getpid_r in no_posix.c doesn't match with newlib's in reent.h.

Release:
RTEMS-4.6-branch + trunk (all)

Attachments (1)

rtems-kill.diff (605 bytes) - added by Ralf Corsepius on Dec 3, 2006 at 1:31:13 PM.
rtems-kill.diff

Download all attachments as: .zip

Change History (2)

comment:1 Changed on Apr 16, 2003 at 6:41:19 PM by Joel Sherrill

Status: assignedclosed

State-Changed-From-To: open->closed
State-Changed-Why: Patch applied to trunk and release branch.

Changed on Dec 3, 2006 at 1:31:13 PM by Ralf Corsepius

Attachment: rtems-kill.diff added

rtems-kill.diff

Note: See TracTickets for help on using tickets.