#388 closed defect (fixed)

snprintf vs. cpukit/libnetworking

Reported by: Ralf Corsepius Owned by: Eric Norum
Priority: normal Milestone: 2
Component: network/legacy Version: unknown
Severity: major Keywords:
Cc: bugs@…, joel.sherrill@… Blocked By:
Blocking:

Description

low qualitity code in libnetworking:

gmake[4]: Entering directory`/users/rtems/src/rtems-cvs/build/arm/arm-rtems/c/edb7312/exec/libnetworking'
arm-rtems-gcc --pipe -DPACKAGE_NAME=\"rtems-cpukit-libnetworking\" -DPACKAGE_TARNAME=\"rtems-cpukit-libnetworking\
" -DPACKAGE_VERSION=\"4.6.0pre1\" -DPACKAGE_STRING=\"rtems-cpukit-libnetworking\ 4.6.0pre1\" -DPACKAGE_BUGREPORT=\
"rtems-bugs@…\" -isystem ../../../.././edb7312/lib/include -D_COMPILING_BSD_KERNEL_ -DKERNEL -DINET -
DNFS -DDIAGNOSTIC -DBOOTP_COMPAT -mcpu=arm7tdmi -mstructure-size-boundary=8 -msoft-float -O3 -g -Wall -o o-o
ptimize/kern_sysctl.o -c ../../../../../../../rtems-4-6-branch/c/src/../../cpukit/libnetworking/kern/kern_sysctl.c
../../../../../../../rtems-4-6-branch/cpukit/libnetworking/kern/kern_sysctl.c: In function `sysctl_sysctl_name':
../../../../../../../rtems-4-6-branch/cpukit/libnetworking/kern/kern_sysctl.c:524: warning: implicit declaration o
f function `snprintf'
../../../../../../../rtems-4-6-branch/cpukit/libnetworking/kern/kern_sysctl.c: In function `sysctl_handle_string':
../../../../../../../rtems-4-6-branch/cpukit/libnetworking/kern/kern_sysctl.c:859: warning: comparison between poi
nter and integer

Release:
RTEMS-4-6-branch

Change History (1)

comment:1 Changed on Apr 15, 2003 at 1:59:33 PM by Joel Sherrill

Status: assignedclosed

State-Changed-From-To: open->closed
State-Changed-Why: Patch applied to branch and development trunk.

2003-04-15 Joel Sherrill <joel@…>


PR 388/networking

  • kern/kern_sysctl.c: Revert previous patch and use strlcpy() now that it is available. Also fixed some warnings.
Note: See TracTickets for help on using tickets.