Opened on 12/26/18 at 00:39:19
Closed on 01/07/19 at 07:45:58
#3670 closed defect (fixed)
examples-v2 uses deprecated or obsolete RTEMS interfaces
Reported by: | Chris Johns | Owned by: | joel@… |
---|---|---|---|
Priority: | high | Milestone: | 5.1 |
Component: | examples | Version: | 5 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
The examples need to be change to use what ever is the newer method of doing something.
../../filesystem/fat_ramdisk/init.c:46:3: warning: 'rtems_blkdev_generic_open' is deprecated [-Wdeprecated-declarations] open_entry: rtems_blkdev_generic_open, ^~~~~~~~~~ In file included from /opt/work/chris/rtems/kernel/5/arm-rtems5/xilinx_zynq_zedboard/lib/include/rtems/ramdisk.h:17:0, from ../../filesystem/fat_ramdisk/init.c:16: /opt/work/chris/rtems/kernel/5/arm-rtems5/xilinx_zynq_zedboard/lib/include/rtems/blkdev.h:408:1: note: declared here rtems_blkdev_generic_open( ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../filesystem/fat_ramdisk/init.c:47:3: warning: 'rtems_blkdev_generic_close' is deprecated [-Wdeprecated-declarations] close_entry: rtems_blkdev_generic_close, ^~~~~~~~~~~
In file included from ../../ticker/low_ticker/init.c:88:0: /opt/work/chris/rtems/kernel/5/arm-rtems5/xilinx_zynq_zedboard/lib/include/rtems/confdefs.h:3276:4: warning: #warning "The CONFIGURE_TERMIOS_DISABLED configuration option is obsolete since RTEMS 5.1" [-Wcpp] #warning "The CONFIGURE_TERMIOS_DISABLED configuration option is obsolete since RTEMS 5.1" ^~~~~~~
Change History (3)
comment:1 follow-up: 2 Changed on 01/04/19 at 06:55:37 by Sebastian Huber
comment:2 Changed on 01/07/19 at 05:29:58 by Chris Johns
Replying to Sebastian Huber:
Should the examples work with all RTEMS versions or just RTEMS 5?
I suppose the examples should be equivalent to what a user sees so in this case they should build with RTEMS 5 and have no errors or warnings. The examples are captured as part of a release which means there is a history and the changes needed for RTEMS.
If I had an application that needed to work with 4.11 and 5 I would detect the version and conditionally handle the changes in the build system and code.
I am OK with them building for RTEMS 5.
comment:3 Changed on 01/07/19 at 07:45:58 by Sebastian Huber
Resolution: | → fixed |
---|---|
Status: | new → closed |
I fixed the issues. Trac didn't update the ticket.
Should the examples work with all RTEMS versions or just RTEMS 5?