Changes between Initial Version and Version 1 of Ticket #3532


Ignore:
Timestamp:
09/27/18 23:08:52 (6 years ago)
Author:
Chris Johns
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3532 – Description

    initial v1  
    1010%endif
    1111}}}
    12 The simpler construct `rtems-tools-common-1.cfg` of:
     12The simpler construct in `rtems-tools-common-1.cfg` of:
    1313{{{
    1414  %ifos win32 mingw ming32
    … …  
    1818  %endif
    1919}}}
    20 is easier to manage as the `%ifos` logic can always return `True` however the `%else` patch also need to be followed and this could break the logic in a configuration file. Yes, the example is not about sources or patches however it shows what could be used.
    21 I do not think adding logic to the configuration file parsing will help, for example consider this case:
     20is easier to manage as the `%ifos` logic can always return `True` however the `%else` path also need to be followed and this could break the logic in a configuration file. Yes, the example is not about sources or patches however it shows what could be used.
     21I do not think creating a new variable such as `%{download_only}`and adding logic to the configuration file will help, for example:
    2222{{{
    23 %if %{_build_os} == freebsd || %{_build_os} == darwin
     23%if %{download_only} || %{_build_os} == freebsd || %{_build_os} == darwin
    2424 %patch add gcc foobar-bsd.patch
    2525%else
    … …  
    2727%endif
    2828}}}
    29 We require the logic to follow the `%if True` path and the `%else` path.
     29We require the logic to follow the `%if True` path '''and''' the `%else` path.