#3501 closed defect (fixed)

MSR_RI defined multiple places

Reported by: Joel Sherrill Owned by: Christian Mauderer
Priority: normal Milestone: 5.1
Component: arch/powerpc Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

Two files define the MSR_RI macro. Since one is a register name on the PowerPC, this shows up on 48 PowerPC BSPs. This is one example.

log/powerpc-qoriq_e6500_64.log:../../../../../../rtems/c/src/../../cpukit/dev/serial/sc16is752-regs.h:117:0: warning: "MSR_RI" redefined
log/powerpc-qoriq_e6500_64.log: #define MSR_RI (1u << 6)
log/powerpc-qoriq_e6500_64.log: #define MSR_RI (1<<1) /* Recoverable Exception */
log/powerpc-qoriq_e6500_64.log:../../../../../../rtems/c/src/../../cpukit/dev/serial/sc16is752-regs.h:117:0: warning: "MSR_RI" redefined
log/powerpc-qoriq_e6500_64.log: #define MSR_RI (1u << 6)
log/powerpc-qoriq_e6500_64.log: #define MSR_RI (1<<1) /* Recoverable Exception */

Change History (3)

comment:1 Changed on Aug 14, 2018 at 11:23:52 PM by Joel Sherrill

Owner: set to Christian Mauderer
Status: newassigned

Assigning to Christian since the git log says he added the file cpukit/dev/serial/sc16is752-regs.h

comment:2 Changed on Aug 15, 2018 at 7:41:32 AM by Christian Mauderer

Also I didn't add the file but only the line in that file, it's quite clearly my responsibility. I was sure that this driver is only used in the ATSAM-BSP. But it seems that it is compiled for every BSP. I'll add a prefix to the register names and send a patch.

comment:3 Changed on Aug 15, 2018 at 3:44:16 PM by Christian Mauderer <christian.mauderer@…>

Resolution: fixed
Status: assignedclosed

In dcaea71/rtems:

dev/sc16is752: Add name space for field names.

The field names for the registers generated a name collision (MSR_RI on
the power pc). This patch adds a SC16IS752_ prefix for all field names.

Closes #3501.

Note: See TracTickets for help on using tickets.