Opened on 03/27/18 at 05:19:46
Closed on 10/15/18 at 05:29:18
#3375 closed enhancement (fixed)
Remove command line pre-processor defines
Reported by: | Sebastian Huber | Owned by: | Sebastian Huber |
---|---|---|---|
Priority: | normal | Milestone: | 5.1 |
Component: | build | Version: | 5 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
Command line defines defined by the build system make it difficult get a consistent view of the sources from other entities, e.g. static code analysis, code editors and reviews.
Command line defines are currently used here:
c/src/lib/libbsp/mips/hurricane/Makefile.am:libbsp_a_CPPFLAGS = $(AM_CPPFLAGS) -DRM52XX c/src/lib/libbsp/mips/rbtx4938/Makefile.am:libbsp_a_CPPFLAGS = $(AM_CPPFLAGS) -DTX49 c/src/lib/libbsp/mips/jmr3904/Makefile.am:libbsp_a_CPPFLAGS = $(AM_CPPFLAGS) -DTX39 cpukit/pppd/Makefile.am:libpppd_a_CPPFLAGS = $(AM_CPPFLAGS) -D__BSD_VISIBLE -I$(srcdir)/../libmd cpukit/libfs/Makefile.am:libjffs2_a_CPPFLAGS += -D__ECOS cpukit/libfs/Makefile.am:libjffs2_a_CPPFLAGS += '-DKBUILD_MODNAME="JFFS2"' cpukit/mghttpd/Makefile.am:# libmghttpd_a_CPPFLAGS += -DHAVE_MD5 cpukit/mghttpd/Makefile.am:libmghttpd_a_CPPFLAGS += -DNO_SSL -DNO_POPEN -DNO_CGI -DUSE_WEBSOCKET cpukit/librpc/Makefile.am:librpc_CPPFLAGS = -D_RPC_read=read -D_RPC_write=write -D_RPC_close=close \ cpukit/libnetworking/Makefile.am:libnetworking_CPPFLAGS = -DINET -DNFS \ cpukit/libnetworking/Makefile.am:libc_CPPFLAGS = -DNOPOLL -DNOSELECT -D__BSD_VISIBLE -D_THREAD_SAFE cpukit/libnetworking/Makefile.am:lib_CPPFLAGS = -DNOPOLL -DNOSELECT cpukit/libnetworking/Makefile.am:lib_a_CPPFLAGS = $(AM_CPPFLAGS) $(lib_CPPFLAGS) -D__BSD_VISIBLE cpukit/libdl/Makefile.am:libdl_a_CPPFLAGS = $(AM_CPPFLAGS) -DRTEMS_RTL_RAP_LOADER=1 -DRTEMS_RTL_ELF_LOADER=1
Change History (16)
comment:1 Changed on 03/27/18 at 06:15:31 by Chris Johns
comment:3 Changed on 03/27/18 at 23:09:52 by Joel Sherrill
For places where the source comes from other places (e.g. JFFS2, etc), what's the approach that doesn't modify the upstream source?
comment:4 follow-up: 5 Changed on 03/28/18 at 05:02:03 by Sebastian Huber
We just have to be careful to avoid potential conflicts with upstream merges. JFFS2 is the only area with an active upstream.
comment:5 Changed on 03/28/18 at 23:25:38 by Chris Johns
Replying to Sebastian Huber:
We just have to be careful to avoid potential conflicts with upstream merges. JFFS2 is the only area with an active upstream.
Thank you.
comment:12 Changed on 10/04/18 at 08:50:47 by Sebastian Huber <sebastian.huber@…>
In f373bdc0/rtems:
comment:16 Changed on 10/15/18 at 05:29:18 by Sebastian Huber <sebastian.huber@…>
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In fb12215/rtems:
What are you thinking of doing?