#3299 new defect

src/c/src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891: bad bitmask ?

Reported by: David Binderman Owned by:
Priority: normal Milestone:
Component: admin Version:
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

[src/c/src/lib/libbsp/arm/stm32f4x/hal/STM32F4xx_HAL_Driver/Src/stm32f4xx_hal_fmpi2c.c:2891]: (style) Same expression on both sides of '|'.

Source code is

/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_FMPI2C_DISABLE_IT(hfmpi2c,FMPI2C_IT_ERRI | FMPI2C_IT_TCI| FMPI2C_IT_STOPI| FMPI2C_IT_NACKI | FMPI2C_IT_ADDRI | FMPI2C_IT_RXI | FMPI2C_IT_RXI );

Comment and code don't match up. Note use of two *RXI at end of expression.

Change History (3)

comment:1 Changed on Feb 14, 2018 at 3:10:13 PM by David Binderman

Same thing in another file.

[src/c/src/lib/libbsp/arm/stm32f7x/hal/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_i2c.c:2904]: (style) Same expression on both sides of '|'.

/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_I2C_DISABLE_IT(hi2c,I2C_IT_ERRI | I2C_IT_TCI| I2C_IT_STOPI| I2C_IT_NACKI | I2C_IT_ADDRI | I2C_IT_RXI | I2C_IT_RXI );

comment:2 Changed on Feb 14, 2018 at 10:13:54 PM by Chris Johns

Version?

comment:3 Changed on Feb 15, 2018 at 7:51:22 AM by David Binderman

The results of a git pull, so trunk I guess.

A simple check on the latest version will help you confirm.

Note: See TracTickets for help on using tickets.