#3117 closed enhancement (fixed)

score: Optimize _Thread_queue_Enqueue() timeout handling

Reported by: Sebastian Huber Owned by: Sebastian Huber
Priority: normal Milestone: 5.1
Component: score Version: 5
Severity: normal Keywords:
Cc: Blocked By:


Use the Thread_queue_Context::enqueue_callout to do the timeout handling. This avoids the switch statement in _Thread_queue_Timeout(). It removes the thread queue dependency to _Thread_Timeout().

Change History (24)

comment:1 Changed on 08/24/17 at 09:52:09 by Sebastian Huber

Summary: score: Optimize _Thread_queue_Enqueue()score: Optimize _Thread_queue_Enqueue() timeout handling

comment:2 Changed on 10/09/17 at 12:18:01 by Sebastian Huber

Milestone: Indefinite4.12.0
Status: assignedaccepted

comment:3 Changed on 10/17/17 at 06:31:01 by Sebastian Huber <sebastian.huber@…>

In bf2a53d2/rtems:

score: Rename watchdog variants

highlight the corresponding POSIX CLOCK_MONOTONIC.

highlight the corresponding POSIX CLOCK_REALTIME.

Update #3117.
Update #3182.

comment:4 Changed on 10/17/17 at 06:31:14 by Sebastian Huber <sebastian.huber@…>

In 91ce012c/rtems:

score: Rename _Watchdog_Per_CPU_insert_monotonic()

Rename _Watchdog_Per_CPU_insert_monotonic() in

Update #3117.
Update #3182.

comment:5 Changed on 10/17/17 at 11:57:07 by Sebastian Huber <sebastian.huber@…>

In 9a583a9/rtems-libbsd:

SLEEPQUEUE(9): Update due to API changes

Update #3117.
Update #3182.

comment:6 Changed on 10/24/17 at 08:20:25 by Sebastian Huber <sebastian.huber@…>

In 02878626/rtems:

score: Add _Thread_Add_timeout_ticks()

Replace _Thread_Timer_insert_monotonic() with

Update #3117.
Update #3182.

comment:7 Changed on 10/24/17 at 08:20:37 by Sebastian Huber <sebastian.huber@…>

In 27cfe7c/rtems:

score: Add _Watchdog_Ticks_per_second

This value is frequently used. Avoid the function call overhead and the
integer division at run-time.

Update #3117.
Update #3182.

comment:8 Changed on 10/24/17 at 08:20:49 by Sebastian Huber <sebastian.huber@…>

In e0dc6ef/rtems:


Remove the cast so that it can be used in C pre-processor directives.

Update #3117.
Update #3182.

comment:9 Changed on 10/24/17 at 08:21:01 by Sebastian Huber <sebastian.huber@…>

In 381ef5c/rtems:

confdefs: Warn about problematic ticks per second

A non-integer clock ticks per second value may lead to inaccurate time
format conversions.

Update #3117.
Update #3182.

comment:10 Changed on 10/24/17 at 08:21:13 by Sebastian Huber <sebastian.huber@…>

In ecef3698/rtems:

score: Rename _Watchdog_Ticks_from_*()

Rename _Watchdog_Ticks_from_*() to _Watchdog_Realtime_from_*().

This highlights that these routines are used for the CLOCK_REALTIME
watchdogs (in contrast to CLOCK_MONOTONIC).

Update #3117.
Update #3182.

comment:11 Changed on 10/24/17 at 08:21:25 by Sebastian Huber <sebastian.huber@…>

In adaf5c23/rtems:

score: _Watchdog_Is_far_future_realtime_timespec()

Update #3117.
Update #3182.

comment:12 Changed on 10/24/17 at 08:21:36 by Sebastian Huber <sebastian.huber@…>

In d16d07f/rtems:

score: Add _Watchdog_Is_valid_interval_timespec()

Update #3117.
Update #3182.

comment:13 Changed on 10/24/17 at 08:21:48 by Sebastian Huber <sebastian.huber@…>

In 7ed377b/rtems:

score: _Watchdog_Is_far_future_monotonic_timespec

Update #3117.
Update #3182.

comment:14 Changed on 10/24/17 at 08:22:00 by Sebastian Huber <sebastian.huber@…>

In cea5ff7/rtems:

score: Add _Watchdog_Nanoseconds_per_tick

Move it from the configuration to a separate variable.

Update #3117.
Update #3182.

comment:15 Changed on 10/24/17 at 08:22:12 by Sebastian Huber <sebastian.huber@…>

In b13ec80/rtems:

score: Add _Watchdog_Monotonic_from_timespec()

Update #3117.
Update #3182.

comment:16 Changed on 10/24/17 at 08:22:24 by Sebastian Huber <sebastian.huber@…>

In 5747962/rtems:

score: _Watchdog_Per_CPU_lazy_insert_monotonic()

Update #3117.
Update #3182.

comment:17 Changed on 10/24/17 at 08:22:36 by Sebastian Huber <sebastian.huber@…>

In 6de1f92/rtems:

score: Add _Thread_Continue()

Update #3117.
Update #3182.

comment:18 Changed on 10/24/17 at 08:22:48 by Sebastian Huber <sebastian.huber@…>

In 1666ffe5/rtems:

score: Rename function threadq support function

Rename _Thread_queue_Context_set_do_nothing_enqueue_callout() into
_Thread_queue_Context_set_enqueue_do_nothing_extra(). More
_Thread_queue_Context_set_enqueue_*() functions will follow.

Update #3117.
Update #3182.

comment:19 Changed on 10/24/17 at 08:23:00 by Sebastian Huber <sebastian.huber@…>

In c3105894/rtems:

score: Move thread queue timeout handling

Update #3117.
Update #3182.

comment:20 Changed on 10/24/17 at 08:52:31 by Sebastian Huber

Resolution: fixed
Status: acceptedclosed

comment:21 Changed on 10/24/17 at 10:20:24 by Sebastian Huber <sebastian.huber@…>

In 2fcf5aa/rtems-libbsd:

rtems-bsd-mutex: Update due to API changes

Update #3117.

comment:22 Changed on 11/09/17 at 06:27:14 by Sebastian Huber


Milestone renamed

comment:23 Changed on 03/22/18 at 07:43:06 by Sebastian Huber <sebastian.huber@…>

In 3da2f471/rtems:

mpci: Update due to thread queue API changes

Update #3117.
Update #3182.

comment:24 Changed on 03/22/18 at 08:06:14 by Sebastian Huber <sebastian.huber@…>

In 7353422f/rtems:

mpci: Fix _MPCI_Enqueue_callout()

Update #3117.
Update #3182.

Note: See TracTickets for help on using tickets.