#3017 closed task (worksforme)

improvement in pci.h

Reported by: phongvanpham Owned by: joel.sherrill@…
Priority: normal Milestone: 5.1
Component: score Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

In pci.h, there are references to BSP_pci_configuration data structure which is in pci.c. However, in this file, there are also references to detect_host_bridge () in detect_raven_bridge.c. For folks that are just interested in pci_read_config_dword() + its brothers, all they need is to include pci.h and content for where BSP_pci_configuration is defined. The rest of the stuff in pci.c should be separate. Or in another word, data structures and #defines involving with BSP_pci_configuration needs to be in separate files rather all stuffed in pci.c

I currently do not need this functionality for my BSP (nor do I able to test it), so I cannot modify code and submit. It is best someone who can test the code to make the code change. Or else, just shelf it under the table and/or close this ticket.

Change History (3)

comment:1 Changed on May 11, 2017 at 7:31:02 AM by Sebastian Huber

Milestone: 4.124.12.0

comment:2 Changed on Jul 13, 2017 at 1:46:29 PM by Joel Sherrill

Resolution: worksforme
Status: newclosed

This shouldn't be an issue since we compile and link with per-function-sections. With this set of options, a function is only included in an executable if it is actually referenced -- not just if it is in a file with a referenced symbol.

FWIW Users using this option with large C++ applications have reported seeing their executables drop in size by half. C applications did get smaller but the RTEMS tests didn't show a huge improvement. Still it did drop some code out.

comment:3 Changed on Nov 9, 2017 at 6:27:14 AM by Sebastian Huber

Milestone: 4.12.05.1

Milestone renamed

Note: See TracTickets for help on using tickets.