Opened on 05/08/17 at 19:33:43

Closed on 05/16/17 at 15:38:07

Last modified on 11/09/17 at 06:27:14

#3010 closed defect (fixed)

src/cpukit/posix/src/mmap.c:189]: (style) Suspicious condition

Reported by: David Binderman Owned by: Gedare Bloom <gedare@…>
Priority: normal Milestone: 5.1
Component: unspecified Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

src/cpukit/posix/src/mmap.c:189]: (style) Suspicious condition (bitwise operator + comparison); Clarify expression with parentheses.

Source code is

} else if ( (flags & MAP_PRIVATE != MAP_PRIVATE) ) {

Maybe better code

} else if ( (flags & MAP_PRIVATE) != MAP_PRIVATE ) {

Change History (3)

comment:1 Changed on 05/11/17 at 07:31:02 by Sebastian Huber

Milestone: 4.12 → 4.12.0

comment:2 Changed on 05/16/17 at 15:38:07 by Gedare Bloom <gedare@…>

Owner: set to Gedare Bloom <gedare@…>
Resolution: → fixed
Status: new → closed

In a330c5d/rtems:

posix: clarify expression with parentheses

Close #3010.

comment:3 Changed on 11/09/17 at 06:27:14 by Sebastian Huber

Milestone: 4.12.0 → 5.1

Milestone renamed

Note: See TracTickets for help on using tickets.