#3002 closed defect (fixed)

Incorrect bit reference in ARM GIC

Reported by: munster Owned by: Sebastian Huber
Priority: normal Milestone: 4.11.2
Component: bsps Version: 4.11
Severity: normal Keywords: ARM, GIC
Cc: Blocked By:
Blocking:

Description

Incorrect bit reference in /c/src/lib/libbsp/arm/shared/include/arm-gic.h, line 46.
The macro GIC_ID_TO_TWO_BITS_REG_OFFSET supposed to convert interrupt ID to an index of a two-bit field in a register.
The correct way is:

#define GIC_ID_TO_TWO_BITS_REG_OFFSET(id) (((id) & 0xfU) << 1)

Change History (5)

comment:1 Changed on May 11, 2017 at 7:31:02 AM by Sebastian Huber

Milestone: 4.124.12.0

comment:2 Changed on May 11, 2017 at 7:55:28 AM by Sebastian Huber <sebastian.huber@…>

In 0e49417/rtems:

bsps/arm: Fix bit field offset in GIC support

Update #3002.

comment:3 Changed on May 11, 2017 at 7:56:20 AM by Sebastian Huber

Milestone: 4.12.04.11.3
Owner: changed from joel.sherrill@… to Sebastian Huber
Status: newaccepted
Version: 4.124.11

comment:4 Changed on May 11, 2017 at 7:58:10 AM by Sebastian Huber <sebastian.huber@…>

Resolution: fixed
Status: acceptedclosed

In 09cbe71/rtems:

bsps/arm: Fix bit field offset in GIC support

Close #3002.

comment:5 Changed on May 11, 2017 at 8:00:00 AM by Sebastian Huber

Milestone: 4.11.34.11.2
Note: See TracTickets for help on using tickets.