Opened on 03/15/17 at 15:24:08

Last modified on 01/30/23 at 05:34:10

#2932 accepted infra

Account manager plugin sends email to all.

Reported by: Amar Takhar Owned by: Amar Takhar
Priority: normal Milestone: Indefinite
Component: unspecified Version:
Severity: normal Keywords: funded project-1
Cc: Blocked By: #4787
Blocking:

Description (last modified by Amar Takhar)

For some reason either the plugin or trac is ignoring the notify settings. Previously the plugin ignored the CC-all setting now it doesn't. This means the verify emails are getting sent out to bugs.

This is a known issue for trac v1.2 see: ​​https://trac-hacks.org/ticket/8796

Change History (13)

comment:1 Changed on 03/15/17 at 15:24:31 by Amar Takhar

Tracking this down has been a pain I'm going to need to take everything down and step it in a debugger.

comment:2 Changed on 10/17/18 at 21:12:17 by Amar Takhar

The solution to this is to create a new TicketPreviousUpdatersSubscriber? Component that will restrict the list of contacts to only those who have registered an account on Trac.

I'll change the SQL from:

SELECT DISTINCT author FROM ticket_change WHERE ticket=%s

To:

SELECT DISTINCT author FROM ticket_change WHERE author IN (SELECT DISTINCT sid from session) and ticket=%s

The reason this is happening in the first place is due to the ticket updater plugin which unilaterally inserts logs from the Git commit. This is fine and what we'd normally want but we don't want to be sending emails to anyone who hasn't updated a ticket directly via an account.

Version 0, edited on 10/17/18 at 21:12:17 by Amar Takhar (next)

comment:3 Changed on 10/20/18 at 14:47:19 by Amar Takhar

Blocked By: 3557 added

comment:4 Changed on 10/20/18 at 15:21:27 by Amar Takhar

Blocked By: 3557 removed

comment:5 Changed on 10/20/18 at 15:55:42 by Amar Takhar

Description: modified (diff)

comment:6 Changed on 10/20/18 at 16:06:18 by Amar Takhar

Resolution: → fixed
Status: assigned → closed

This was fixed in:

​https://trac-hacks.org/changeset/14276

See ticket:

​https://trac-hacks.org/ticket/8796

I upgraded to the latest so we should no longer be getting password reset / signup emails.

comment:7 Changed on 10/20/18 at 16:06:37 by Amar Takhar

Description: modified (diff)

Reference right ticket.

comment:8 Changed on 10/23/18 at 21:13:40 by Amar Takhar

Resolution: fixed
Status: closed → reopened

This is not fixed the verification emails are still going to bugs@.

comment:9 Changed on 01/19/23 at 16:35:49 by Amar Takhar

Blocked By: 4787 added
Keywords: need-funding added; trac removed

comment:10 Changed on 01/19/23 at 16:41:43 by Amar Takhar

Milestone: → Indefinite
Priority: high → normal

comment:11 Changed on 01/25/23 at 21:03:40 by Amar Takhar

Keywords: This project has been funded by an anonymous donor thank you! added; need-funding removed
Status: reopened → accepted

funded project-1

comment:12 Changed on 01/30/23 at 05:24:29 by Amar Takhar

This will require installation of the trunk version to work with Trac 1.4.

comment:13 Changed on 01/30/23 at 05:34:10 by Amar Takhar

Keywords: project-1 added; This project has been by an anonymous donor thank you! removed

Fix typo made two edits ago.

Note: See TracTickets for help on using tickets.