src/cpukit/libdebugger/rtems-debugger-server.c: four problems

[David Binderman]

1.

src/cpukit/libdebugger/rtems-debugger-server.c:1306]: (style) Redundant condition: extended. '!extended || (extended && check_pid(pid))' is equivalent to '!extended || check_pid(pid)'

Suggest simplify.

2.

src/cpukit/libdebugger/rtems-debugger-server.c:1858]: (warning) Possible null pointer dereference: rtems_debugger

Source code is

  if (r < 0) {
    rtems_printf(printer, "error: rtems-db: remote begin: %s: %s\n",
                 rtems_debugger->remote->name, strerror(errno));
    free(rtems_debugger);
    rtems_debugger = NULL;
  }

  /*
   * Reset at the end of the session.
   */
  rtems_debugger->flags = 0;

Suggest adding return -1 inside the if.

3.

src/cpukit/libdebugger/rtems-debugger-server.c:906]: (style) Redundant condition: extended. '!extended || (extended && check_pid(pid))' is equivalent to '!extended || check_pid(pid)'

Duplicate.

4.

src/cpukit/libdebugger/rtems-debugger-server.c:956]: (warning) Char literal compared with pointer 'p'. Did you intend to dereference it?

Source code is

  while (p != NULL && p != '\0') {

Maybe better code

  while (p != NULL && *p != '\0') {

[Chris Johns]

Update formatting to show the code fragments.

[Chris Johns <chrisj@…>]

In b2353ed9/rtems:

libdebugger: Fixes to debugging, ARM support, locking, and gcc-7.1 warnings.

• Add printk support to aid multi-core debugging.
• Add lock trace to aid lock debugging.
• Fixes to gcc-7.1 warnings.
• Fixes from ticket #2879.
• Add verbose command controls.
• Change using the RTEMS sys/lock.h API to manage exception threads.
• ARM hardware breakpoint fixes. Support for SMP stepping is not implemented, this requires use of the context id register.

Closes #2879.

[Sebastian Huber]

Milestone renamed