Opened on 05/15/16 at 23:01:05

Last modified on 08/14/17 at 00:11:59

#2712 new defect

_rtems_octal2ulong shared by tar code.

Reported by: Chris Johns Owned by:
Priority: normal Milestone: Indefinite
Component: fs Version: 5
Severity: normal Keywords: tar
Cc: Blocked By:
Blocking:

Description

The function _rtems_octal2ulong provided in cpukit/libmisc/untar/untar.c is used internally in this file plus it is used in the IMFS load tar implementation.

These are separate implementations and this small piece of code joins these modules together. Sure, function level linking helps but I do not thinks we should share this code

Why not use 'strtoul(str, &end, 8)' to convert the octal number?

Change History (4)

comment:1 Changed on 03/27/17 at 06:48:47 by Chris Johns

Milestone: 4.12.1 → 4.12.0

Move to the first 4.12 milestone.

comment:2 Changed on 06/08/17 at 08:20:02 by Sebastian Huber

Milestone: 4.12.0 → Indefinite

comment:3 Changed on 06/08/17 at 08:21:27 by Sebastian Huber

strtoul() pulls in the locale support. We should ban this function from the RTEMS core.

comment:4 Changed on 08/14/17 at 00:11:59 by Chris Johns

Version: 4.11 → 4.12
Note: See TracTickets for help on using tickets.