#2700 closed defect (fixed)

cpukit/libfs/src/nfsclient/src/rpcio.c:524]: (style) Suspicious condition

Reported by: David Binderman Owned by: Sebastian Huber <sebastian.huber@…>
Priority: normal Milestone: 5.1
Component: unspecified Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:


cpukit/libfs/src/nfsclient/src/rpcio.c:524]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ( (len = getgroups(NGROUPS, gids) < 0 ) ) {

maybe better code

if ( (len = getgroups(NGROUPS, gids)) < 0 ) {

Change History (5)

comment:1 Changed on Jan 20, 2017 at 3:17:24 PM by David Binderman

Still broken nine months later.

comment:2 Changed on Jan 23, 2017 at 1:39:44 PM by Sebastian Huber <sebastian.huber@…>

Owner: set to Sebastian Huber <sebastian.huber@…>
Resolution: fixed
Status: newclosed

In c0151e6c6486ce3ae3623e616326fae626f32eb2/rtems:

nfsclient: Fix suspicious condition

Close #2700.

comment:3 Changed on Jan 23, 2017 at 1:40:22 PM by Sebastian Huber


comment:4 Changed on May 11, 2017 at 7:31:02 AM by Sebastian Huber


comment:5 Changed on Nov 9, 2017 at 6:27:14 AM by Sebastian Huber


Milestone renamed

Note: See TracTickets for help on using tickets.