#2683 closed defect (invalid)

Configuration table's smp_enabled conditional on RTEMS_SMP

Reported by: Chris Johns Owned by: Sebastian Huber
Priority: normal Milestone: 5.1
Component: score Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by Chris Johns)

The rtems_configuration_table has:

  #ifdef RTEMS_SMP
    bool                         smp_enabled;
  #endif

I would like the smp_enabled variable to always be defined for 4.12 and always set to false when RTEMS_SMP is not defined. It is impossible to parse the configuration table with external auditing tools with out this field always being present unless you examine the DWARF debug info.

I wonder if User_multiprocessing_table is the same so this means the members of the configuration table must always be defined.

Chris

Change History (6)

comment:1 Changed on Apr 4, 2016 at 1:48:55 AM by Chris Johns

Description: modified (diff)

comment:2 Changed on Apr 4, 2016 at 5:27:59 AM by Sebastian Huber

Yes, the top-level configuration tables should contain no pre-processor stuff.

comment:3 Changed on Apr 4, 2016 at 9:05:18 AM by Joel Sherrill

With per function/data element linking, will the smp enabled variable even make it to a linked uniprocessor exe if SMP is disabled and the variable is always false? There will be no code to reference it.

comment:4 in reply to:  3 Changed on Apr 4, 2016 at 9:23:58 PM by Chris Johns

Replying to joel.sherrill:

With per function/data element linking, will the smp enabled variable even make it to a linked uniprocessor exe if SMP is disabled and the variable is always false? There will be no code to reference it.

It is in the configuration table. All that is being suggested to always have the elements in the table. There is no code.

comment:5 Changed on Feb 15, 2017 at 2:25:52 PM by Sebastian Huber

Milestone: 4.12Indefinite
Owner: set to Sebastian Huber
Status: newassigned

comment:6 Changed on Mar 31, 2020 at 10:59:06 AM by Sebastian Huber

Milestone: Indefinite5.1
Resolution: invalid
Status: assignedclosed

The configuration table not longer exists. In particular, the SMP enabled indicator is no longer used. The User_multiprocessing_table no longer exists. In MPCI configurations, there is now an _MPCI_Configuration.

Last edited on Mar 31, 2020 at 10:59:35 AM by Sebastian Huber (previous) (diff)
Note: See TracTickets for help on using tickets.