#2678 new enhancement

possible unnecessary includes in console drivers

Reported by: Joel Sherrill Owned by: Joel Sherrill
Priority: low Milestone: Indefinite
Component: bsps Version:
Severity: minor Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by Joel Sherrill)

I am making a sweep to eliminate the include of <rtems/console.h> from <bsp.h>. This involves adding it to a few console drivers. I am seeing includes of multiple files that I am suspicious are not needed or should be corrected:

  • <malloc.h>
  • <rtems/mw_uid.h>
  • <fcntl.h>
  • use of <assert.h> - there are 100s of asserts. This is beyond my current activities.
  • <stdio.h>
  • some comments that <bsp.h> must be included before <rtems/libio.h>

I reordering in some to try a pattern of include files as follows:

  • standard C/POSIX .h files
  • standard RTEMS files without <rtems.h> as first
  • <bsp.h>
  • private .h files

This may not work but could be part of the remove rtems/console.h from bsp.h patch series.

I will not be able to investigate immediately so am filing a ticket for future follow up.

Change History (4)

comment:1 Changed on Mar 29, 2016 at 1:22:23 PM by Joel Sherrill

Description: modified (diff)

comment:2 Changed on Mar 30, 2016 at 3:21:26 PM by Joel Sherrill

Description: modified (diff)

comment:3 Changed on May 11, 2017 at 7:31:02 AM by Sebastian Huber

Milestone: 4.124.12.0

comment:4 Changed on Jun 8, 2017 at 7:35:15 AM by Sebastian Huber

Milestone: 4.12.0Indefinite
Version: 4.12
Note: See TracTickets for help on using tickets.