#267 closed defect (fixed)

m68k cpu_asm.S does not always honor ISR nest level

Reported by: brett.swimley Owned by: Joel Sherrill
Priority: normal Milestone: 2
Component: score Version: 4.5
Severity: major Keywords:
Cc: bugs@… Blocked By:
Blocking:

Description

Attached is a patch to c\src\exec\score\cpu\m68k\cpu_asm.S which changes the
_ISR_Nest_level variable. This patch is applied to the rtems-ss-20020301
snapshot. The _ISR_Handler() function never was modifying _ISR_Nest_level,
and _Watchdog_Insert() requires this variable to be modified to determine if
an interrupt may have modified the watchdog chain.

FWIW, I used the file c\src\lib\libbsp\m68k\gen68340\console\Modif_cpu_asm.S
as a model.

Prior to modifying _ISR_Handler(), I had a test that would fail if
_ISR_Flash was not commented out in _Watchdog_Insert(). After this
modification was made, my test ran flawlessly.

It seems that this change should be made regardless, to follow the
_ISR_Handler model?

Release:
RTEMS-4.5 and CVS

Attachments (1)

rtems-ss-20020301-m68k-cpu_asm.diff (2.3 KB) - added by brett.swimley on Dec 3, 2006 at 1:31:13 PM.
rtems-ss-20020301-m68k-cpu_asm.diff

Download all attachments as: .zip

Change History (2)

comment:1 Changed on Aug 14, 2002 at 10:07:43 PM by Joel Sherrill

Status: assignedclosed

State-Changed-From-To: open->closed
State-Changed-Why: Patch applied. FYI I made this a PR even though it was

open only a short time so someone else might be able to
find this fix. It has probably been needed for a long time.

Changed on Dec 3, 2006 at 1:31:13 PM by brett.swimley

rtems-ss-20020301-m68k-cpu_asm.diff

Note: See TracTickets for help on using tickets.