![[RTEMS Logo]](/images/logo.png){kind=logo}
#2542 closed defect (fixed)
Review cxx_iostream size change per function-section changes
| Reported by: | Joel Sherrill | Owned by: | joel.sherrill@… |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | bsps | Version: | 5 |
| Severity: | normal | Keywords: | |
| Cc: | Ralph Holmes | Blocked By: | |
| Blocking: |
Description
It looks like some BSPs with their own linkcmds may have shrunk too much. Norm appears to be 50% while some went to 75-80%. A second look after catching the pattern indicates that the KEEP() section requirements in the linker scripts were not correct and it was missed.
Rather than reverting a bunch of patches, this ticket is to review all function-section patches from this one back in time for cxx_iostream shrinking too much.
commit 6d21c13e5094d490280a941cf0e8333f91f85715
Author: Ralph Holmes <ralph@…>
Date: Sat Jan 23 21:15:40 2016 +0000
powerpc/gen5200: Add per-section compilation and linking support.
For the brs5l BSP variant:
Change History (8)
comment:1 Changed on 01/23/16 at 22:25:02 by Joel Sherrill
comment:2 Changed on 01/23/16 at 22:27:17 by Joel Sherrill
| Component: | General → bsps |
|---|---|
| Milestone: | 4.11.1 → 4.12 |
| Owner: | set to joel.sherrill@… |
| Version: | 4.10 → 4.12 |
comment:3 Changed on 01/23/16 at 22:36:47 by Joel Sherrill
After a review of all potential BSPs, I have determined that these are the ones which are almost certainly missing KEEP() sections. This drops the set considerably.
As a practical matter, the BSPs will be converted to use a shared linkcmds.base or have the use of function-sections disabled by commenting out the added lines. We need to work out the details but the same comment should be added above those lines like this (review and approve):
# This BSP does not either (a) use a shared linkcmds base file or (b) include
# proper KEEP() directives in its linkcmds* files. Because of these arguments
# can not currently be enabled.
powerpc/mbx8xx: Add per-section compilation and linking support. - removed per #2545.
powerpc/haleakala: Add per-section compilation and linking support. - #2561.
powerpc/ss555: Add per-section compilation and linking support. - #2563.
powerpc/qemuppc: Add per-section compilation and linking support. - #2564.
powerpc/mpc8260ads: Add per-section compilation and linking support. #2565.
m68k/mvme162: Add per-section compilation and linking support. - now uses shared
m68k/gen68360: Add per-section compilation and linking support. - #2566.
m68k/mvme147s: Add per-section compilation and linking support. - now uses shared
m68k/mvme147: Add per-section compilation and linking support. - now uses shared
m68k/mrm332: Add per-section compilation and linking support. - #2657.
m68k/mcf5225x: Add per-section compilation and linking support. - #2568.
m68k/mcf5329: Add per-section compilation and linking support. - #2569.
m68k/mcf52235: Add per-section compilation and linking support. - #2570.
m68k/mcf5235: Add per-section compilation and linking support. - #2571.
m68k/mcf5206elite: Add per-section compilation and linking support. - #2572.
m68k/gen68340: Add per-section compilation and linking support. - #2573.
m68k/av5282: Add per-section compilation and linking support. - #2574.
m68k/mvme167: Add per-section compilation and linking support. - now uses shared
m68k/gen68302: Add per-section compilation and linking support. - removed per #2543.
m68k/uC5282: Add per-section compilation and linking support.
m68k/ods68302: Add per-section compilation and linking support. - removed per #2544.
arm/lpc176x: Add per-section compilation and linking support
comment:4 Changed on 01/25/16 at 20:14:25 by Joel Sherrill <joel@…>
comment:5 Changed on 02/06/16 at 16:26:17 by Joel Sherrill
All BSPs which had function sections enabled and clearly broke cxx_iostream should now have per function section linking disabled and a separate ticket filed.
comment:6 Changed on 02/06/16 at 16:26:33 by Joel Sherrill
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:7 Changed on 05/11/17 at 07:31:02 by Sebastian Huber
| Milestone: | 4.12 → 4.12.0 |
|---|
comment:8 Changed on 11/09/17 at 06:27:14 by Sebastian Huber
| Milestone: | 4.12.0 → 5.1 |
|---|
Milestone renamed
The following commits were made before this was noticed. Only those with a large cxx_iostream shrinkage or no cxx_iostream size need review.