#2522 new defect

RSB can sometimes change the wrong local git repository (includes a fix).

Reported by: Goetz Pfeiffer Owned by: Chris Johns
Priority: normal Milestone: 4.10.3
Component: tool/rsb Version: 4.10
Severity: normal Keywords: RSB git
Cc: Blocked By:


It function in RSB that checks if a local git repository is valid can return True if a valid git repository is not present but can be found further up the directory hierarchy. This can cause RSB to alter an unrelated git repository somewhere else. The patch attached here fixes this problem. I searched half a day why RSB changed an unrelated repo and this prevents happening this to anybody else...

Attachments (1)

git-safer-repo-validation.patch (1.6 KB) - added by Goetz Pfeiffer on Jan 12, 2016 at 9:56:50 AM.
Make RSBs check of a git repo more safe

Download all attachments as: .zip

Change History (3)

Changed on Jan 12, 2016 at 9:56:50 AM by Goetz Pfeiffer

Make RSBs check of a git repo more safe

comment:1 Changed on Aug 14, 2017 at 12:51:22 AM by Chris Johns

Milestone: 4.10.3

comment:2 Changed on Feb 13, 2018 at 12:22:48 AM by Chris Johns

The patch should use path.join() and not directly call os.path.join().

Note: See TracTickets for help on using tickets.