Opened on 01/12/16 at 09:56:22
Last modified on 02/13/18 at 00:22:48
#2522 new defect
RSB can sometimes change the wrong local git repository (includes a fix).
Reported by: | Goetz Pfeiffer | Owned by: | Chris Johns |
---|---|---|---|
Priority: | normal | Milestone: | 4.10.3 |
Component: | tool/rsb | Version: | 4.10 |
Severity: | normal | Keywords: | RSB git |
Cc: | Blocked By: | ||
Blocking: |
Description
It function in RSB that checks if a local git repository is valid can return True if a valid git repository is not present but can be found further up the directory hierarchy. This can cause RSB to alter an unrelated git repository somewhere else. The patch attached here fixes this problem. I searched half a day why RSB changed an unrelated repo and this prevents happening this to anybody else...
Attachments (1)
Change History (3)
Changed on 01/12/16 at 09:56:50 by Goetz Pfeiffer
Attachment: | git-safer-repo-validation.patch added |
---|
comment:1 Changed on 08/14/17 at 00:51:22 by Chris Johns
Milestone: | → 4.10.3 |
---|
comment:2 Changed on 02/13/18 at 00:22:48 by Chris Johns
The patch should use path.join()
and not directly call os.path.join()
.
Note: See
TracTickets for help on using
tickets.
Make RSBs check of a git repo more safe