#2496 assigned defect

rtems/c/src/lib/libbsp/sparc/shared/amba/ambapp.c:258: possible bad test ?

Reported by: David Binderman Owned by: Daniel Hellstrom
Priority: normal Milestone: 4.11.4
Component: arch/sparc Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

[rtems/c/src/lib/libbsp/sparc/shared/amba/ambapp.c:258]: (error) Memory leak: apbdev

apbdev = ambapp_alloc_dev_struct(DEV_APB_SLV);
if (!dev)

return -1;

Maybe better code

apbdev = ambapp_alloc_dev_struct(DEV_APB_SLV);
if (!apbdev)

return -1;

Looks like a cut-n-paste error and then some inadequate testing to me.

Change History (7)

comment:1 Changed on Dec 16, 2015 at 6:32:51 AM by Sebastian Huber

Owner: set to Daniel Hellstrom
Status: newassigned

comment:2 Changed on Jan 26, 2017 at 7:16:00 AM by Sebastian Huber

Milestone: 4.11.14.11.2

comment:3 Changed on Mar 23, 2017 at 1:03:28 AM by Chris Johns

Milestone: 4.11.24.11.3

The 4.11.2 milestone is closing.

comment:4 Changed on Mar 23, 2017 at 1:05:42 AM by Chris Johns

Version: 4.104.11

Move to the 4.11 branch.

comment:6 Changed on Feb 7, 2018 at 10:02:08 PM by Chris Johns

Component: unspecifiedarch/sparc

comment:7 Changed on Feb 11, 2018 at 11:40:41 PM by Chris Johns

Milestone: 4.11.34.11.4

Move to the next milestone and Daniel will resolved them for the next release.

Note: See TracTickets for help on using tickets.