Opened on Nov 12, 2015 at 3:16:08 PM
Last modified on Feb 15, 2017 at 1:37:51 PM
#2467 assigned defect
tems/c/src/lib/libbsp/arm/stm32f7x/hal/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_i2c.c:2904: possibl bad expression
Reported by: | David Binderman | Owned by: | Needs Funding |
---|---|---|---|
Priority: | normal | Milestone: | Indefinite |
Component: | unspecified | Version: | 4.10 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description
[rtems/c/src/lib/libbsp/arm/stm32f7x/hal/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_i2c.c:2904]: (style) Same expression on both sides of '|'.
Source code is
/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_I2C_DISABLE_IT(hi2c,I2C_IT_ERRI | I2C_IT_TCI| I2C_IT_STOPI| I2C_IT_NACKI | I2C_IT_ADDRI | I2C_IT_RXI | I2C_IT_RXI );
Maybe better code would be to ensure the comment and the code match up
as follows
/* Disable ERRI, TCI, STOPI, NACKI, ADDRI, RXI, TXI interrupt */
HAL_I2C_DISABLE_IT(hi2c,I2C_IT_ERRI | I2C_IT_TCI| I2C_IT_STOPI| I2C_IT_NACKI | I2C_IT_ADDRI | I2C_IT_RXI | I2C_IT_TXI );
Change History (2)
comment:1 Changed on Jan 26, 2017 at 7:16:00 AM by Sebastian Huber
Milestone: | 4.11.1 → 4.11.2 |
---|
comment:2 Changed on Feb 15, 2017 at 1:37:51 PM by Sebastian Huber
Milestone: | 4.11.2 → Indefinite |
---|---|
Owner: | set to Needs Funding |
Status: | new → assigned |
Note: See
TracTickets for help on using
tickets.