#2456 closed defect (fixed)

Warning in beagle bbb-gpio.c

Reported by: Joel Sherrill Owned by: Ben Gras
Priority: normal Milestone: 4.11
Component: bsps Version: 5
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

../../../../../../../../rtems/c/src/lib/libbsp/arm/beagle/gpio/bbb-gpio.c:258:19: warning: no previous prototype for 'rtems_bsp_select_specific_io' [-Wmissing-prototypes]

Attachments (1)

fix-2456.txt (1.8 KB) - added by Ben Gras on Nov 3, 2015 at 5:05:02 PM.

Download all attachments as: .zip

Change History (5)

comment:1 Changed on Nov 3, 2015 at 5:04:43 PM by Ben Gras

The earlier rename (commit 5c337d7) missed this case - the implementations in the beagle and rpi bsp's weren't renamed. rtems_bsp_select_specific_io -> rtems_gpio_bsp_select_specific_io. Proposed fix to be attached.

Changed on Nov 3, 2015 at 5:05:02 PM by Ben Gras

Attachment: fix-2456.txt added

comment:2 Changed on Nov 3, 2015 at 5:11:39 PM by Joel Sherrill

I trust you on the fix. If you think it is right, just commit it. I was just going through warnings on a build sweep.

comment:3 Changed on Nov 3, 2015 at 6:58:43 PM by Ben Gras

Tested a rtems build & gpio app build, so should be fine.

comment:4 Changed on Nov 3, 2015 at 6:59:33 PM by Ben Gras <beng@…>

Resolution: fixed
Status: newclosed

In 2502e26ddae7c8b5780b89c5d3b85fbe5b9ca6fa/rtems:

Leftover gpio function rename

Rename rtems_bsp_select_specific_io to rtems_gpio_bsp_select_specific_io.

Should've gone with 5c337d7. Fixes #2456.

Note: See TracTickets for help on using tickets.