#2393 assigned defect

rtems/c/src/lib/libbsp/sparc/shared/1553/b1553brm.c:992: bad if test ?

Reported by: David Binderman Owned by: Daniel Hellstrom
Priority: normal Milestone: 4.11.4
Component: arch/sparc Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

[rtems/c/src/lib/libbsp/sparc/shared/1553/b1553brm.c:992]: (style) Unsigned variable 'count' can't be negative so it is unnecessary to test it.

Source code is

if (count >= 0) {

return RTEMS_SUCCESSFUL;

}
return RTEMS_UNSATISFIED;

Which means that the second return is dead code. Suggest code rework.

Change History (9)

comment:1 Changed on Jan 20, 2017 at 2:10:34 PM by David Binderman

Still broken, nearly a year and a half later.

comment:2 Changed on Jan 20, 2017 at 2:12:10 PM by Sebastian Huber

Owner: set to Sebastian Huber
Status: newassigned

comment:3 Changed on Jan 20, 2017 at 2:12:26 PM by Sebastian Huber

Owner: changed from Sebastian Huber to Joel Sherrill

comment:4 Changed on Jan 20, 2017 at 2:12:45 PM by Sebastian Huber

Owner: changed from Joel Sherrill to Daniel Hellstrom

comment:5 Changed on Jan 26, 2017 at 7:16:00 AM by Sebastian Huber

Milestone: 4.11.14.11.2

comment:6 Changed on Mar 23, 2017 at 1:03:28 AM by Chris Johns

Milestone: 4.11.24.11.3

The 4.11.2 milestone is closing.

comment:7 Changed on Mar 23, 2017 at 1:05:42 AM by Chris Johns

Version: 4.104.11

Move to the 4.11 branch.

comment:8 Changed on Feb 7, 2018 at 10:01:57 PM by Chris Johns

Component: unspecifiedarch/sparc

comment:9 Changed on Feb 11, 2018 at 11:40:41 PM by Chris Johns

Milestone: 4.11.34.11.4

Move to the next milestone and Daniel will resolved them for the next release.

Note: See TracTickets for help on using tickets.