#2376 closed defect (fixed)

close() of tftpfs always returns an error

Reported by: Michael Davidsaver Owned by: Michael Davidsaver <mdavidsaver@…>
Priority: normal Milestone: 4.10.3
Component: network/legacy Version: 4.10
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

While investigating #2375 I find that rtems_tftp_close() in tftpDriver.c unconditionally calls rtems_set_errno_and_return_minus_one(). So successful close() returns -1 and sets errno==0.

A proposed fix https://github.com/mdavidsaver/rtems/commit/348f7ed7d1e5ee6cf13d945967d349edb47e549b

Change History (3)

comment:1 Changed on Jul 29, 2015 at 4:16:06 PM by Michael Davidsaver <mdavidsaver@…>

Owner: set to Michael Davidsaver <mdavidsaver@…>
Resolution: fixed
Status: newclosed

In 74ef2c101a2a8ac2cb4c32ae0da8061e2b76886a/rtems:

tftpDriver: close() false error

closes #2376.

comment:2 Changed on Jul 29, 2015 at 4:17:25 PM by Michael Davidsaver <mdavidsaver@…>

In 8da63adc4b166ad5355f96a96022d4835493f361/rtems:

tftpDriver: close() false error

closes #2376.

comment:3 Changed on Jul 29, 2015 at 4:21:22 PM by Michael Davidsaver <mdavidsaver@…>

In a4e052b53fb10f0cf2e3c1f4681710ab9912fbcd/rtems:

tftpDriver: close() false error

closes #2376.

Note: See TracTickets for help on using tickets.