#2302 closed defect (fixed)

beagle BSPs - warning because of bad symbol name choice

Reported by: Joel Sherrill Owned by: Ben Gras
Priority: normal Milestone: 4.11
Component: unspecified Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

The macro TIMER_COUNT is not prefixed by anything ARM, Beagle, etc. and conflicts with the use of the same name in sp68. I am not even sure this constant is used. It either needs to be renamed or deleted.

arm-rtems4.11-gcc -B../../../../../beagleboardorig/lib/ -specs bsp_specs -qrtems -DHAVE_CONFIG_H -I. -I../../../../../../../rtems/c/src/../../testsuites/sptests/sp68 -I.. -I../../../../../../../rtems/c/src/../../testsuites/sptests/../support/include -mcpu=cortex-a8 -O2 -g -Wall -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes -Wnested-externs -MT init.o -MD -MP -MF .deps/init.Tpo -c -o init.o ../../../../../../../rtems/c/src/../../testsuites/sptests/sp68/init.c
../../../../../../../rtems/c/src/../../testsuites/sptests/sp68/init.c:35:0: warning: "TIMER_COUNT" redefined

#define TIMER_COUNT 6

In file included from ../../../../../../../rtems/c/src/../../testsuites/sptests/../support/include/tmacros.h:21:0,

from ../../../../../../../rtems/c/src/../../testsuites/sptests/sp68/init.c:26:

../../../../../beagleboardorig/lib/include/bsp.h:119:0: note: this is the location of the previous definition

#define TIMER_COUNT(freq) (TIMER_FREQ/(freq)) /* initial value for counter*/

Change History (3)

comment:1 Changed on Mar 14, 2015 at 3:07:05 PM by Ben Gras

testing a change to fix this now.

comment:2 Changed on Mar 14, 2015 at 5:51:02 PM by Ben Gras

tested; submitted the change for merging.

comment:3 Changed on Mar 14, 2015 at 8:42:58 PM by Ben Gras <beng@…>

Resolution: fixed
Status: newclosed

In 86204bdeb554289c3eaf66efbc5057d0614ad076/rtems:

beagle bsp: delete TIMER_FREQ, TIMER_COUNT

unused and poorly named (no prefix) and colliding with sp68.

Closes #2302.

Note: See TracTickets for help on using tickets.